Michael Howell
7560a2b9b6
Use embedded SVG instead of fonts for icons
...
The [downsides of icon fonts] are well-documented, and also, why ship all of
the icons when it only uses 14?
[downsides of icon fonts]: https://speakerdeck.com/ninjanails/death-to-icon-fonts
2022-09-18 15:04:05 -07:00
Eric Huss
c8db0c8ec6
Merge pull request #1889 from mgeisler/simplify-and-then
...
Simplify the use of `Option::and_then`
2022-09-12 09:16:21 -07:00
Martin Geisler
3958260353
Simplify the use of `Option::and_then`
...
I found a few places where `Option::and_then` could be simplified (in
my opinion) with `?` or with `match`.
2022-09-11 00:46:26 +02:00
Eric Huss
8cdb8d0367
Merge pull request #1887 from mgeisler/edition-2021
...
Require Rust 2021 edition
2022-09-09 13:14:33 -07:00
Dylan DPC
66bf85b14f
Require Rust 2021 edition
...
This allows us to clean up and simplify the code.
2022-09-09 16:00:35 +02:00
Dylan DPC
1a0892745e
Merge pull request #1881 from GuillaumeGomez/unneeded-attribute
...
Remove unneeded `type` attribute for `<script>`
2022-08-30 10:53:11 +05:30
Guillaume Gomez
76b0493fb0
Remove unneeded type attribute for <script>
2022-08-29 21:07:50 +02:00
Chris Lovett
74eb4059d6
add a --chapter option to mdbook test. ( #1741 )
...
Sometimes when working on large books it is handy to be able to run mdbook on a single chapter of a book.
2022-08-25 19:13:51 -07:00
Dylan DPC
13f53eb64f
Merge pull request #1876 from joepio/patch-1
...
Explain how to use `site-url` with asset URLs
2022-08-23 14:33:02 +05:30
Joep Meindertsma
b3941526cb
Explain how to use `site-url`
...
Make sure people use the right kind of asset-urls. This issue only shows up when deploying, not using `mdbook serve`.
2022-08-23 10:33:25 +02:00
Eric Huss
fff067b2a8
Merge pull request #1836 from mgeisler/trim-trailing-whitespace
...
Avoid empty last line in editable code blocks
2022-08-10 19:55:06 -07:00
Martin Geisler
217546c2a0
Trim trailing whitespace in Rust code blocks
...
Before, a code block would always end with a final newline. The
newline was added unconditionally by `hide_lines`.
When the code block is syntax highlighted by highlight.js, this is not
a problem, no empty line is added for a final trailing `\n` character.
However, when the code block is editable and thus handled by the ACE
editor, a trailing newline _is_ significant. I believe this issue is
most closely described by https://github.com/ajaxorg/ace/issues/2083
in the upstream repository.
The effect of the way ACE handles newlines is that a code block like
<pre>
Some code
</pre>
will create an editor with _two_ lines, not just one.
By trimming trailing whitespace, we ensure that we don’t accidentally
create more lines in the ACE editor than necessary.
2022-08-10 03:11:08 +02:00
Eric Huss
40c06f5e77
Merge pull request #1863 from ehuss/bump-version
...
Update to 0.4.21
2022-07-22 11:06:12 -07:00
Eric Huss
bb09caa9a3
Update to 0.4.21
2022-07-22 10:54:53 -07:00
Eric Huss
8f01d0234f
Merge pull request #1861 from mitchmindtree/nightly-borrowcheck-err-workaround
...
Workaround rust nightly borrowcheck error (#1860 )
2022-07-22 07:26:28 -07:00
mitchmindtree
13035baeae
Workaround rust nightly borrowcheck error ( #1860 )
...
Surprisingly, this fixes the error filed at #1860 !
This seems suspicious, perhaps indicative of a bug in Rust's non-lexical
lifetime handling?
The lifetimes in the `handlebars::Renderable::render` method signature
are quite complicated, and its unclear to me whether or not Rust is
catching some new safety edge-case that wasn't previously handled
correctly...
Possibly related to `drop` order, which I *think* is related to the
order of binding statements?
2022-07-22 15:15:12 +10:00
Eric Huss
92afe9bd3c
Merge pull request #1857 from ehuss/bump-version
...
Update to 0.4.20
2022-07-14 14:26:20 -07:00
Eric Huss
4c1aca0abb
Update to 0.4.20
2022-07-14 13:46:56 -07:00
Eric Huss
da166e051d
Merge pull request #1855 from stevenengler/code-fmt
...
Fix code padding in headings
2022-07-13 18:06:49 -07:00
Steven Engler
6a4ba95926
Fixed code padding in headings
2022-07-13 19:12:33 -04:00
Eric Huss
6688bd8d7b
Merge pull request #1849 from FauconFan/fix_author(s)_in_user_guide
...
authors -> author in user guide
2022-07-09 13:55:51 -07:00
Dylan DPC
01313a39cc
Merge pull request #1851 from FauconFan/revert-1848-remove_non_exhaustive
...
Revert "remove __non_exhaustive members, add non_exhaustive attribute instead"
2022-07-09 21:51:04 +05:30
Joseph Priou
f92911b8aa
Revert "remove __non_exhaustive members, add non_exhaustive attribute instead"
2022-07-09 17:43:17 +02:00
Dylan DPC
42d6fd5804
Merge pull request #1848 from FauconFan/remove_non_exhaustive
...
remove __non_exhaustive members, add non_exhaustive attribute instead
2022-07-09 19:18:25 +05:30
Fauconfan
a8a45a5fbe
authors -> author in user guide
2022-07-09 15:31:00 +02:00
Fauconfan
11781f0c1b
remove __non_exhaustive members, add non_exhaustive attribute instead
2022-07-09 15:05:06 +02:00
Eric Huss
53055e0345
Merge pull request #1840 from ehuss/fix-lock
...
Fix Cargo.lock for version bump.
2022-07-01 15:46:36 -07:00
Eric Huss
1af6d4b0ec
Fix Cargo.lock for version bump.
2022-07-01 15:44:18 -07:00
Eric Huss
3e311dc975
Merge pull request #1838 from ehuss/bump-version
...
Update to 0.4.19
2022-07-01 15:23:01 -07:00
Eric Huss
04e31eb07b
Update to 0.4.19
2022-07-01 14:55:25 -07:00
Eric Huss
eb82ddca0b
Merge pull request #1837 from ehuss/serve-info
...
Always show the "serving on" info for `mdbook serve`.
2022-07-01 14:54:04 -07:00
Eric Huss
1d2b720ebe
Always show the "serving on" info for `mdbook serve`.
2022-07-01 14:36:18 -07:00
Eric Huss
4c303c3b1d
Merge pull request #1830 from ISSOtm/serve
...
Always open index page with `serve --open`
2022-07-01 13:18:47 -07:00
ISSOtm
42129c6181
Always open index page with `serve --open`
2022-07-01 09:01:25 +02:00
Eric Huss
a10a57e67d
Merge pull request #1829 from ISSOtm/index
...
Fix up "index page" functionality
2022-06-29 17:55:11 -07:00
ISSOtm
fa5f32c7fd
Make link to first chapter active in index page
...
Makes both pages more consistent, and also the previous test pass
Co-authored-by: Eric Huss <eric@huss.org>
2022-06-29 23:51:18 +02:00
ISSOtm
a91e888575
Add test for index page
2022-06-29 08:48:49 +02:00
ISSOtm
8571883923
Mark the first chapter as "index", even if not the first book item
2022-06-29 08:35:41 +02:00
Eric Huss
4cf005d4bd
Merge pull request #1832 from ISSOtm/clippy
...
Fix Clippy lints
2022-06-27 14:28:39 -07:00
Eric Huss
b38792c166
Merge pull request #1833 from mattheww/2022-06_searchindex
...
Omit words longer than 80 characters from the search index
2022-06-27 14:17:40 -07:00
ISSOtm
248863addf
Fix Clippy lints
...
Also remove `allow(clippy::*)`s where possible
2022-06-27 23:08:45 +02:00
Eric Huss
7e2752e71f
Merge pull request #1834 from ehuss/update-deps
...
Update some dependencies
2022-06-27 13:58:40 -07:00
Eric Huss
cbf0ca027d
Merge pull request #1806 from ehuss/button-overlap
...
Make code buttons appear on hover (or tap on mobile)
2022-06-27 13:58:17 -07:00
Eric Huss
2c2ba636a9
Update pretty_assertions from 0.6.1 to 1.2.1
2022-06-27 13:29:22 -07:00
Eric Huss
494e6722b2
Update env_logger from 0.7.1 to 0.9.0
...
This drops quick-error 1.2.3 from the tree
2022-06-27 13:29:22 -07:00
Eric Huss
ddf71222c5
Bump tokio from 1.10.0 to 1.16.1
2022-06-27 13:29:18 -07:00
Eric Huss
1d89127d8f
Mention how to uninstall.
...
Closes #1822 .
2022-06-27 11:10:09 -07:00
Eric Huss
5f00625c14
Merge pull request #1617 from lf-/x-overflow
...
Fix some x overflows
2022-06-27 11:01:48 -07:00
Matthew Woodcraft
000a93dc77
Test that long words are omitted from the search index.
...
Note they do appear in the 'docs' part of searchindex.json (so they will be
visible in search teasers).
2022-06-26 12:22:52 +01:00
Matthew Woodcraft
1f8c090a5f
When creating the search index, omit words longer than 80 characters
...
This avoids creating deeply nested objects in searchindex.json
2022-06-26 12:22:52 +01:00