From a1c9ad90212ad4f8c7c1858906484ddb059ef872 Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 12:53:38 +0530 Subject: [PATCH 01/12] Update versions.yml --- .github/workflows/versions.yml | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index 8078deac..dcc6ed52 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -1,15 +1,7 @@ name: versions on: - pull_request: - paths-ignore: - - '**.md' - push: - branches: - - main - - releases/* - paths-ignore: - - '**.md' + workflow_dispatch: jobs: local-cache: From 1f73a3b53e1657b095598ce7fbf7195b190c5fb9 Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 12:56:19 +0530 Subject: [PATCH 02/12] Update versions.yml --- .github/workflows/versions.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index dcc6ed52..8078deac 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -1,7 +1,15 @@ name: versions on: - workflow_dispatch: + pull_request: + paths-ignore: + - '**.md' + push: + branches: + - main + - releases/* + paths-ignore: + - '**.md' jobs: local-cache: From 48d16174726b097dad6d40d91017110b7643d94c Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 14:02:07 +0530 Subject: [PATCH 03/12] Update versions.yml --- .github/workflows/versions.yml | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index 8078deac..3b7054b2 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -1,15 +1,11 @@ name: versions on: - pull_request: - paths-ignore: - - '**.md' push: branches: - - main - - releases/* - paths-ignore: - - '**.md' + - nvm-issue-fix + + jobs: local-cache: @@ -43,6 +39,14 @@ jobs: with: node-version: ${{ matrix.node-version }} check-latest: true + + - name: Install NVM + if: runner.os == 'Linux' + run: | + curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash + export NVM_DIR="$HOME/.nvm" + [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" + [ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" - if: runner.os != 'Windows' && runner.os != 'macOS' name: Verify node and npm run: | From a4b94e20d0b2abdba18873c83082b5e02eba0d3f Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 14:03:15 +0530 Subject: [PATCH 04/12] Update versions.yml --- .github/workflows/versions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index 3b7054b2..7dafb90f 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 From 70be4f16403554bfbf8cbdcc9d5d6db4bbd459b0 Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 14:05:33 +0530 Subject: [PATCH 05/12] Update versions.yml --- .github/workflows/versions.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index 7dafb90f..de7d00dc 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -30,7 +30,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-13] + os: [ubuntu-24.04, windows-latest, macos-13] node-version: [lts/dubnium, lts/erbium, lts/fermium, lts/*, lts/-1] steps: - uses: actions/checkout@v4 @@ -60,7 +60,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [ '20-v8-canary', @@ -85,7 +85,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [20.11.0-nightly202312211a0be537da, 21-nightly, 18.0.0-nightly] steps: @@ -106,7 +106,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [20.0.0-rc.1, 18.0.0-rc.2, 19.0.0-rc.0] steps: - uses: actions/checkout@v4 @@ -126,7 +126,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [18.20.0, 20.10.0, 22.0.0] steps: - uses: actions/checkout@v4 @@ -143,7 +143,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 @@ -161,7 +161,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version-file: [.nvmrc, .tool-versions, .tool-versions-node, package.json] steps: @@ -178,7 +178,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] steps: - uses: actions/checkout@v4 - name: Setup node from node version file @@ -193,7 +193,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] steps: - uses: actions/checkout@v4 - name: Setup node from node version file @@ -208,7 +208,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [17, 19] steps: - uses: actions/checkout@v4 @@ -225,7 +225,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-13] + os: [ubuntu-24.04, windows-latest, macos-13] steps: - uses: actions/checkout@v4 # test old versions which didn't have npm and layout different @@ -255,7 +255,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-latest, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest] node-version: [current, latest, node] steps: - name: Get node version From 0fe4194162e29a776bd25c2bc109a78942015435 Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 14:08:34 +0530 Subject: [PATCH 06/12] Update versions.yml --- .github/workflows/versions.yml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index de7d00dc..51ff5fea 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -34,19 +34,22 @@ jobs: node-version: [lts/dubnium, lts/erbium, lts/fermium, lts/*, lts/-1] steps: - uses: actions/checkout@v4 + - name: Install NVM + if: runner.os == 'Linux' + run: | + curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash + echo 'export NVM_DIR="$HOME/.config/nvm"' >> $GITHUB_ENV + echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $GITHUB_ENV + echo '[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"' >> $GITHUB_ENV + - name: Source NVM + if: runner.os == 'Linux' + run: | + source $GITHUB_ENV - name: Setup Node uses: ./ with: node-version: ${{ matrix.node-version }} check-latest: true - - - name: Install NVM - if: runner.os == 'Linux' - run: | - curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash - export NVM_DIR="$HOME/.nvm" - [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" - [ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion" - if: runner.os != 'Windows' && runner.os != 'macOS' name: Verify node and npm run: | From 9d6bd53ee58a21e4ec53ddb3843fb9c9303bc10a Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 14:11:13 +0530 Subject: [PATCH 07/12] Update versions.yml --- .github/workflows/versions.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index 51ff5fea..bdb99970 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -53,9 +53,9 @@ jobs: - if: runner.os != 'Windows' && runner.os != 'macOS' name: Verify node and npm run: | - . "$NVM_DIR/nvm.sh" - [[ $(nvm version-remote "${{ matrix.node-version }}") =~ ^v([^.]+) ]] - __tests__/verify-node.sh "${BASH_REMATCH[1]}" + node_version=$(node --version) + major_version=${node_version:1:2} + __tests__/verify-node.sh "$major_version" shell: bash v8-canary-syntax: From 7afaaa44b1429fcc34d4c5078254576b9010f56f Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 14:17:23 +0530 Subject: [PATCH 08/12] Update versions.yml --- .github/workflows/versions.yml | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index bdb99970..e2f57f0e 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -34,17 +34,6 @@ jobs: node-version: [lts/dubnium, lts/erbium, lts/fermium, lts/*, lts/-1] steps: - uses: actions/checkout@v4 - - name: Install NVM - if: runner.os == 'Linux' - run: | - curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.3/install.sh | bash - echo 'export NVM_DIR="$HOME/.config/nvm"' >> $GITHUB_ENV - echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $GITHUB_ENV - echo '[ -s "$NVM_DIR/bash_completion" ] && \. "$NVM_DIR/bash_completion"' >> $GITHUB_ENV - - name: Source NVM - if: runner.os == 'Linux' - run: | - source $GITHUB_ENV - name: Setup Node uses: ./ with: From 0fb7f56828a2271f0b8a2fe1db882c9e12674c2a Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Mon, 30 Sep 2024 19:16:05 +0530 Subject: [PATCH 09/12] Update versions.yml --- .github/workflows/versions.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index e2f57f0e..82674e21 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -39,8 +39,8 @@ jobs: with: node-version: ${{ matrix.node-version }} check-latest: true - - if: runner.os != 'Windows' && runner.os != 'macOS' - name: Verify node and npm + + - name: Verify node and npm run: | node_version=$(node --version) major_version=${node_version:1:2} From 9643ce53f182a44f00e84a2b2932a1c03e7f9cdd Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Wed, 9 Oct 2024 17:58:38 +0530 Subject: [PATCH 10/12] Update versions.yml --- .github/workflows/versions.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/versions.yml b/.github/workflows/versions.yml index 82674e21..e9f7e87e 100644 --- a/.github/workflows/versions.yml +++ b/.github/workflows/versions.yml @@ -13,7 +13,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 @@ -52,7 +52,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [ '20-v8-canary', @@ -77,7 +77,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [20.11.0-nightly202312211a0be537da, 21-nightly, 18.0.0-nightly] steps: @@ -98,7 +98,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [20.0.0-rc.1, 18.0.0-rc.2, 19.0.0-rc.0] steps: - uses: actions/checkout@v4 @@ -118,7 +118,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [18.20.0, 20.10.0, 22.0.0] steps: - uses: actions/checkout@v4 @@ -135,7 +135,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [18, 20, 22] steps: - uses: actions/checkout@v4 @@ -153,7 +153,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version-file: [.nvmrc, .tool-versions, .tool-versions-node, package.json] steps: @@ -170,7 +170,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] steps: - uses: actions/checkout@v4 - name: Setup node from node version file @@ -185,7 +185,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] steps: - uses: actions/checkout@v4 - name: Setup node from node version file @@ -200,7 +200,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [17, 19] steps: - uses: actions/checkout@v4 @@ -247,7 +247,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-24.04, windows-latest, macos-latest] + os: [ubuntu-24.04, windows-latest, macos-latest, macos-13] node-version: [current, latest, node] steps: - name: Get node version From 8adc8da25fa14935f083024678af14f17f132fed Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Wed, 9 Oct 2024 17:59:35 +0530 Subject: [PATCH 11/12] Update release-new-action-version.yml --- .github/workflows/release-new-action-version.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-new-action-version.yml b/.github/workflows/release-new-action-version.yml index d8171ef8..7e5de347 100644 --- a/.github/workflows/release-new-action-version.yml +++ b/.github/workflows/release-new-action-version.yml @@ -22,7 +22,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Update the ${{ env.TAG_NAME }} tag - uses: actions/publish-action@v0.2.2 + uses: actions/publish-action@v0.3.0 with: source-tag: ${{ env.TAG_NAME }} slack-webhook: ${{ secrets.SLACK_WEBHOOK }} From bcbd21499e02b028df7ad1453927ccff48f4f02e Mon Sep 17 00:00:00 2001 From: aparnajyothi-y <147696841+aparnajyothi-y@users.noreply.github.com> Date: Wed, 9 Oct 2024 18:00:05 +0530 Subject: [PATCH 12/12] Update e2e-cache.yml --- .github/workflows/e2e-cache.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e-cache.yml b/.github/workflows/e2e-cache.yml index f9d3aaf2..34872b96 100644 --- a/.github/workflows/e2e-cache.yml +++ b/.github/workflows/e2e-cache.yml @@ -46,7 +46,7 @@ jobs: steps: - uses: actions/checkout@v4 - name: Install pnpm - uses: pnpm/action-setup@v2 + uses: pnpm/action-setup@v4 with: version: 6.10.0 - name: Generate pnpm file