actions
/
setup-node
Template
mirror of https://github.com/actions/setup-node
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Formatter

This commit is contained in:
Gordey Doronin 2021-06-22 16:11:44 +02:00
parent 56c3db9dda
commit d9ce83b637
2 changed files with 173 additions and 63 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

184
__tests__/installer.test.ts
View File

@ -134,7 +134,7 @@ describe('setup-node', () => {
let match = await tc.findFromManifest('12.16.2', true, versions); let match = await tc.findFromManifest('12.16.2', true, versions);
expect(match).toBeDefined(); expect(match).toBeDefined();
expect(match?.version).toBe('12.16.2'); expect(match?.version).toBe('12.16.2');
expect((match as any).lts).toBe('Erbium') expect((match as any).lts).toBe('Erbium');
}); });
it('can find 12 from manifest on linux', async () => { it('can find 12 from manifest on linux', async () => {
@ -149,7 +149,7 @@ describe('setup-node', () => {
let match = await tc.findFromManifest('12.16.2', true, versions); let match = await tc.findFromManifest('12.16.2', true, versions);
expect(match).toBeDefined(); expect(match).toBeDefined();
expect(match?.version).toBe('12.16.2'); expect(match?.version).toBe('12.16.2');
expect((match as any).lts).toBe('Erbium') expect((match as any).lts).toBe('Erbium');
}); });
it('can find 10 from manifest on windows', async () => { it('can find 10 from manifest on windows', async () => {
@ -164,7 +164,7 @@ describe('setup-node', () => {
let match = await tc.findFromManifest('10', true, versions); let match = await tc.findFromManifest('10', true, versions);
expect(match).toBeDefined(); expect(match).toBeDefined();
expect(match?.version).toBe('10.20.1'); expect(match?.version).toBe('10.20.1');
expect((match as any).lts).toBe('Dubnium') expect((match as any).lts).toBe('Dubnium');
}); });
//-------------------------------------------------- //--------------------------------------------------
@ -399,7 +399,9 @@ describe('setup-node', () => {
expect(logSpy).not.toHaveBeenCalledWith( expect(logSpy).not.toHaveBeenCalledWith(
'Attempt to resolve the latest version from manifest...' 'Attempt to resolve the latest version from manifest...'
); );
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') expect(dbgSpy).not.toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
}); });
it('check latest version and resolve it from local cache', async () => { it('check latest version and resolve it from local cache', async () => {
@ -420,7 +422,9 @@ describe('setup-node', () => {
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
'Attempt to resolve the latest version from manifest...' 'Attempt to resolve the latest version from manifest...'
); );
expect(dbgSpy).toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') expect(dbgSpy).toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(logSpy).toHaveBeenCalledWith("Resolved as '12.16.2'"); expect(logSpy).toHaveBeenCalledWith("Resolved as '12.16.2'");
expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`); expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`);
}); });
@ -445,7 +449,9 @@ describe('setup-node', () => {
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
'Attempt to resolve the latest version from manifest...' 'Attempt to resolve the latest version from manifest...'
); );
expect(dbgSpy).toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') expect(dbgSpy).toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(logSpy).toHaveBeenCalledWith("Resolved as '12.16.2'"); expect(logSpy).toHaveBeenCalledWith("Resolved as '12.16.2'");
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
`Acquiring 12.16.2 - ${os.arch} from ${expectedUrl}` `Acquiring 12.16.2 - ${os.arch} from ${expectedUrl}`
@ -482,7 +488,9 @@ describe('setup-node', () => {
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
'Attempt to resolve the latest version from manifest...' 'Attempt to resolve the latest version from manifest...'
); );
expect(dbgSpy).toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') expect(dbgSpy).toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(logSpy).toHaveBeenCalledWith( expect(logSpy).toHaveBeenCalledWith(
`Failed to resolve version ${versionSpec} from manifest` `Failed to resolve version ${versionSpec} from manifest`
); );
@ -553,13 +561,25 @@ describe('setup-node', () => {
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') );
expect(dbgSpy).toHaveBeenCalledWith(`LTS alias 'erbium' for Node version 'lts/erbium'`) expect(dbgSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith(`Found LTS release '12.16.2' for Node version 'lts/erbium'`) 'Getting manifest from actions/node-versions@main'
);
expect(dbgSpy).not.toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(dbgSpy).toHaveBeenCalledWith(
`LTS alias 'erbium' for Node version 'lts/erbium'`
);
expect(dbgSpy).toHaveBeenCalledWith(
`Found LTS release '12.16.2' for Node version 'lts/erbium'`
);
expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`); expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`);
expect(cnSpy).toHaveBeenCalledWith(`::add-path::${toolPath}/bin${osm.EOL}`); expect(cnSpy).toHaveBeenCalledWith(
`::add-path::${toolPath}/bin${osm.EOL}`
);
}); });
it('find latest LTS version and install it from manifest (lts/erbium)', async () => { it('find latest LTS version and install it from manifest (lts/erbium)', async () => {
@ -575,23 +595,38 @@ describe('setup-node', () => {
dlSpy.mockImplementation(async () => '/some/temp/path'); dlSpy.mockImplementation(async () => '/some/temp/path');
exSpy.mockImplementation(async () => '/some/other/temp/path'); exSpy.mockImplementation(async () => '/some/other/temp/path');
cacheSpy.mockImplementation(async () => toolPath); cacheSpy.mockImplementation(async () => toolPath);
const expectedUrl = 'https://github.com/actions/node-versions/releases/download/12.16.2-20200423.28/node-12.16.2-linux-x64.tar.gz'; const expectedUrl =
'https://github.com/actions/node-versions/releases/download/12.16.2-20200423.28/node-12.16.2-linux-x64.tar.gz';
// act // act
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') );
expect(dbgSpy).toHaveBeenCalledWith(`LTS alias 'erbium' for Node version 'lts/erbium'`) expect(dbgSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith(`Found LTS release '12.16.2' for Node version 'lts/erbium'`) 'Getting manifest from actions/node-versions@main'
expect(logSpy).toHaveBeenCalledWith("Attempting to download 12..."); );
expect(logSpy).toHaveBeenCalledWith(`Acquiring 12.16.2 - ${os.arch} from ${expectedUrl}`); expect(dbgSpy).not.toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(dbgSpy).toHaveBeenCalledWith(
`LTS alias 'erbium' for Node version 'lts/erbium'`
);
expect(dbgSpy).toHaveBeenCalledWith(
`Found LTS release '12.16.2' for Node version 'lts/erbium'`
);
expect(logSpy).toHaveBeenCalledWith('Attempting to download 12...');
expect(logSpy).toHaveBeenCalledWith(
`Acquiring 12.16.2 - ${os.arch} from ${expectedUrl}`
);
expect(logSpy).toHaveBeenCalledWith('Extracting ...'); expect(logSpy).toHaveBeenCalledWith('Extracting ...');
expect(logSpy).toHaveBeenCalledWith('Adding to the cache ...'); expect(logSpy).toHaveBeenCalledWith('Adding to the cache ...');
expect(cnSpy).toHaveBeenCalledWith(`::add-path::${toolPath}/bin${osm.EOL}`); expect(cnSpy).toHaveBeenCalledWith(
}) `::add-path::${toolPath}/bin${osm.EOL}`
);
});
it('find latest LTS version and resolve it from local cache (lts/*)', async () => { it('find latest LTS version and resolve it from local cache (lts/*)', async () => {
// arrange // arrange
@ -608,13 +643,25 @@ describe('setup-node', () => {
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') );
expect(dbgSpy).toHaveBeenCalledWith(`LTS alias '*' for Node version 'lts/*'`) expect(dbgSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith(`Found LTS release '14.0.0' for Node version 'lts/*'`) 'Getting manifest from actions/node-versions@main'
);
expect(dbgSpy).not.toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(dbgSpy).toHaveBeenCalledWith(
`LTS alias '*' for Node version 'lts/*'`
);
expect(dbgSpy).toHaveBeenCalledWith(
`Found LTS release '14.0.0' for Node version 'lts/*'`
);
expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`); expect(logSpy).toHaveBeenCalledWith(`Found in cache @ ${toolPath}`);
expect(cnSpy).toHaveBeenCalledWith(`::add-path::${toolPath}/bin${osm.EOL}`); expect(cnSpy).toHaveBeenCalledWith(
`::add-path::${toolPath}/bin${osm.EOL}`
);
}); });
it('find latest LTS version and install it from manifest (lts/*)', async () => { it('find latest LTS version and install it from manifest (lts/*)', async () => {
@ -630,23 +677,38 @@ describe('setup-node', () => {
dlSpy.mockImplementation(async () => '/some/temp/path'); dlSpy.mockImplementation(async () => '/some/temp/path');
exSpy.mockImplementation(async () => '/some/other/temp/path'); exSpy.mockImplementation(async () => '/some/other/temp/path');
cacheSpy.mockImplementation(async () => toolPath); cacheSpy.mockImplementation(async () => toolPath);
const expectedUrl = 'https://github.com/actions/node-versions/releases/download/14.0.0-20200423.30/node-14.0.0-linux-x64.tar.gz'; const expectedUrl =
'https://github.com/actions/node-versions/releases/download/14.0.0-20200423.30/node-14.0.0-linux-x64.tar.gz';
// act // act
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(dbgSpy).not.toHaveBeenCalledWith('No manifest cached, getting manifest from actions/node-versions@main') );
expect(dbgSpy).toHaveBeenCalledWith(`LTS alias '*' for Node version 'lts/*'`) expect(dbgSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith(`Found LTS release '14.0.0' for Node version 'lts/*'`) 'Getting manifest from actions/node-versions@main'
expect(logSpy).toHaveBeenCalledWith("Attempting to download 14..."); );
expect(logSpy).toHaveBeenCalledWith(`Acquiring 14.0.0 - ${os.arch} from ${expectedUrl}`); expect(dbgSpy).not.toHaveBeenCalledWith(
'No manifest cached, getting manifest from actions/node-versions@main'
);
expect(dbgSpy).toHaveBeenCalledWith(
`LTS alias '*' for Node version 'lts/*'`
);
expect(dbgSpy).toHaveBeenCalledWith(
`Found LTS release '14.0.0' for Node version 'lts/*'`
);
expect(logSpy).toHaveBeenCalledWith('Attempting to download 14...');
expect(logSpy).toHaveBeenCalledWith(
`Acquiring 14.0.0 - ${os.arch} from ${expectedUrl}`
);
expect(logSpy).toHaveBeenCalledWith('Extracting ...'); expect(logSpy).toHaveBeenCalledWith('Extracting ...');
expect(logSpy).toHaveBeenCalledWith('Adding to the cache ...'); expect(logSpy).toHaveBeenCalledWith('Adding to the cache ...');
expect(cnSpy).toHaveBeenCalledWith(`::add-path::${toolPath}/bin${osm.EOL}`); expect(cnSpy).toHaveBeenCalledWith(
}) `::add-path::${toolPath}/bin${osm.EOL}`
);
});
it('fail with unexpected LTS alias (lts/)', async () => { it('fail with unexpected LTS alias (lts/)', async () => {
// arrange // arrange
@ -662,9 +724,15 @@ describe('setup-node', () => {
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(cnSpy).toHaveBeenCalledWith(`::error::Unexpected LTS alias '' for Node version 'lts/'${osm.EOL}`) );
expect(dbgSpy).toHaveBeenCalledWith(
'Getting manifest from actions/node-versions@main'
);
expect(cnSpy).toHaveBeenCalledWith(
`::error::Unexpected LTS alias '' for Node version 'lts/'${osm.EOL}`
);
}); });
it('fail to find LTS version (lts/unknown)', async () => { it('fail to find LTS version (lts/unknown)', async () => {
@ -681,10 +749,18 @@ describe('setup-node', () => {
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(dbgSpy).toHaveBeenCalledWith(`LTS alias 'unknown' for Node version 'lts/unknown'`) );
expect(cnSpy).toHaveBeenCalledWith(`::error::Unable to find LTS release 'unknown' for Node version 'lts/unknown'.${osm.EOL}`) expect(dbgSpy).toHaveBeenCalledWith(
'Getting manifest from actions/node-versions@main'
);
expect(dbgSpy).toHaveBeenCalledWith(
`LTS alias 'unknown' for Node version 'lts/unknown'`
);
expect(cnSpy).toHaveBeenCalledWith(
`::error::Unable to find LTS release 'unknown' for Node version 'lts/unknown'.${osm.EOL}`
);
}); });
it('fail if manifest is not available', async () => { it('fail if manifest is not available', async () => {
@ -705,9 +781,15 @@ describe('setup-node', () => {
await main.run(); await main.run();
// assert // assert
expect(logSpy).toHaveBeenCalledWith('Attempt to resolve LTS alias from manifest...') expect(logSpy).toHaveBeenCalledWith(
expect(dbgSpy).toHaveBeenCalledWith('Getting manifest from actions/node-versions@main') 'Attempt to resolve LTS alias from manifest...'
expect(cnSpy).toHaveBeenCalledWith(`::error::Unable to download manifest${osm.EOL}`) );
}) expect(dbgSpy).toHaveBeenCalledWith(
}) 'Getting manifest from actions/node-versions@main'
);
expect(cnSpy).toHaveBeenCalledWith(
`::error::Unable to download manifest${osm.EOL}`
);
});
});
}); });

52
src/installer.ts
View File

@ -42,9 +42,14 @@ export async function getNode(
if (isLtsAlias(versionSpec)) { if (isLtsAlias(versionSpec)) {
core.info('Attempt to resolve LTS alias from manifest...'); core.info('Attempt to resolve LTS alias from manifest...');
core.debug('Getting manifest from actions/node-versions@main') core.debug('Getting manifest from actions/node-versions@main');
// No try-catch since it's not possible to resolve LTS alias without manifest // No try-catch since it's not possible to resolve LTS alias without manifest
manifest = await tc.getManifestFromRepo('actions', 'node-versions', auth, 'main'); manifest = await tc.getManifestFromRepo(
'actions',
'node-versions',
auth,
'main'
);
versionSpec = resolveLtsAliasFromManifest(versionSpec, stable, manifest); versionSpec = resolveLtsAliasFromManifest(versionSpec, stable, manifest);
} }
@ -81,7 +86,13 @@ export async function getNode(
// Try download from internal distribution (popular versions only) // Try download from internal distribution (popular versions only)
// //
try { try {
info = await getInfoFromManifest(versionSpec, stable, auth, osArch, manifest); info = await getInfoFromManifest(
versionSpec,
stable,
auth,
osArch,
manifest
);
if (info) { if (info) {
core.info( core.info(
`Acquiring ${info.resolvedVersion} - ${info.arch} from ${info.downloadUrl}` `Acquiring ${info.resolvedVersion} - ${info.arch} from ${info.downloadUrl}`
@ -186,7 +197,7 @@ export async function getNode(
} }
function isLtsAlias(versionSpec: string): boolean { function isLtsAlias(versionSpec: string): boolean {
return versionSpec.startsWith('lts') return versionSpec.startsWith('lts');
} }
function resolveLtsAliasFromManifest( function resolveLtsAliasFromManifest(
@ -197,21 +208,30 @@ function resolveLtsAliasFromManifest(
const alias = versionSpec.split('lts/')[1]?.toLowerCase(); const alias = versionSpec.split('lts/')[1]?.toLowerCase();
if (!alias) { if (!alias) {
throw new Error(`Unexpected LTS alias '${alias}' for Node version '${versionSpec}'`); throw new Error(
`Unexpected LTS alias '${alias}' for Node version '${versionSpec}'`
);
} }
core.debug(`LTS alias '${alias}' for Node version '${versionSpec}'`); core.debug(`LTS alias '${alias}' for Node version '${versionSpec}'`);
// Supported formats are `lts/<alias>` and `lts/*`. Where asterisk means highest possible LTS. // Supported formats are `lts/<alias>` and `lts/*`. Where asterisk means highest possible LTS.
const release = alias === '*' const release =
? manifest.find(x => !!x.lts && x.stable === stable) alias === '*'
: manifest.find(x => x.lts?.toLowerCase() === alias && x.stable === stable); ? manifest.find(x => !!x.lts && x.stable === stable)
: manifest.find(
x => x.lts?.toLowerCase() === alias && x.stable === stable
);
if (!release) { if (!release) {
throw new Error(`Unable to find LTS release '${alias}' for Node version '${versionSpec}'.`); throw new Error(
`Unable to find LTS release '${alias}' for Node version '${versionSpec}'.`
);
} }
core.debug(`Found LTS release '${release.version}' for Node version '${versionSpec}'`); core.debug(
`Found LTS release '${release.version}' for Node version '${versionSpec}'`
);
return release.version.split('.')[0]; return release.version.split('.')[0];
} }
@ -225,7 +245,9 @@ async function getInfoFromManifest(
): Promise<INodeVersionInfo | null> { ): Promise<INodeVersionInfo | null> {
let info: INodeVersionInfo | null = null; let info: INodeVersionInfo | null = null;
if (!manifest) { if (!manifest) {
core.debug('No manifest cached, getting manifest from actions/node-versions@main') core.debug(
'No manifest cached, getting manifest from actions/node-versions@main'
);
manifest = await tc.getManifestFromRepo( manifest = await tc.getManifestFromRepo(
'actions', 'actions',
@ -290,7 +312,13 @@ async function resolveVersionFromManifest(
manifest: tc.IToolRelease[] | undefined manifest: tc.IToolRelease[] | undefined
): Promise<string | undefined> { ): Promise<string | undefined> {
try { try {
const info = await getInfoFromManifest(versionSpec, stable, auth, osArch, manifest); const info = await getInfoFromManifest(
versionSpec,
stable,
auth,
osArch,
manifest
);
return info?.resolvedVersion; return info?.resolvedVersion;
} catch (err) { } catch (err) {
core.info('Unable to resolve version from manifest...'); core.info('Unable to resolve version from manifest...');