actions
/
setup-node
Template
mirror of https://github.com/actions/setup-node
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: add warning for when arch is supplied but version is missing

This commit is contained in:
Amin Yahyaabadi 2020-09-06 11:09:41 -05:00
parent 2801f51f90
commit 2a5c060ce2
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dist/index.js vendored
View File

@ -4645,6 +4645,11 @@ function run() {
version = core.getInput('version'); version = core.getInput('version');
} }
let arch = core.getInput('node-arch'); let arch = core.getInput('node-arch');
// if node-arch supplied but node-version is not
// if we don't throw a warning, the already installed x64 node will be used which is not probably what user meant.
if (arch && !version) {
core.warning('`node-arch` is provided but `node-version` is missing. This results in using an already installed x64 node which is not probably what you meant. To fix this, provide `node-arch` in combination with `node-version`');
}
if (!arch) { if (!arch) {
arch = os.arch(); arch = os.arch();
} }

9
src/main.ts
View File

@ -17,6 +17,15 @@ export async function run() {
} }
let arch = core.getInput('node-arch'); let arch = core.getInput('node-arch');
// if node-arch supplied but node-version is not
// if we don't throw a warning, the already installed x64 node will be used which is not probably what user meant.
if (arch && !version) {
core.warning(
'`node-arch` is provided but `node-version` is missing. This results in using an already installed x64 node which is not probably what you meant. To fix this, provide `node-arch` in combination with `node-version`'
);
}
if (!arch) { if (!arch) {
arch = os.arch(); arch = os.arch();
} }