Merge pull request #237 from aminya/docker-publish

.github/workflows/CI.yml

@@ -55,7 +55,7 @@ jobs:
       - name: Build
         run: |
           pnpm build
-          pnpm build.docker_tests
+          pnpm build.docker-ci
 
       - name: Lint
         run: |
@@ -215,7 +215,7 @@ jobs:
           node ./dist/actions/setup-cpp.js --help
 
   Docker:
-    name: Test-${{ matrix.container }}
+    name: Docker-${{ matrix.container.image }}
     if: ${{ !contains(github.event.head_commit.message, '[skip ci]') }}
     needs: [Build]
     runs-on: ${{ matrix.os }}
@@ -229,12 +229,12 @@ jobs:
         pnpm:
           - 8
         container:
-          - "ubuntu.dockerfile"
+          - { file: "ubuntu-llvm.dockerfile", image: "setup-cpp-ubuntu-llvm", tag: "22.04-0.37.0" }
-          - "fedora.dockerfile"
+          - { file: "fedora-llvm.dockerfile", image: "setup-cpp-fedora-llvm", tag: "40-0.37.0" }
-          - "arch.dockerfile"
+          - { file: "arch-llvm.dockerfile", image: "setup-cpp-arch-llvm", tag: "base-0.37.0" }
-          - "ubuntu-mingw.dockerfile"
+          - { file: "ubuntu-mingw.dockerfile", image: "setup-cpp-ubuntu-mingw", tag: "22.04-0.37.0" }
-          # - "fedora-mingw.dockerfile"
+          # - { file: "fedora-mingw.dockerfile", image: "setup-cpp-fedora-mingw", tag: "40-0.37.0" }
-          # - "arch-mingw.dockerfile"
+          # - { file: "arch-mingw.dockerfile", image: "setup-cpp-arch-mingw", tag: "base-0.37.0" }
     steps:
       - uses: actions/checkout@v4
         with:
@@ -245,10 +245,28 @@ jobs:
         with:
           name: dist
 
-      - name: Build
+      - name: Login to Docker Hub
-        id: docker_build
+        uses: docker/login-action@v3
-        run: |
+        if: ${{ github.event_name != 'pull_request' }}
-          docker build -f ./dev/docker/__tests__/${{ matrix.container }} -t setup-cpp .
+        with:
+          username: ${{ vars.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+
+      - name: Build and push
+        uses: docker/build-push-action@v5
+        with:
+          context: .
+          file: ./dev/docker/ci/${{ matrix.container.file }}
+          push: ${{ github.event_name != 'pull_request' }}
+          tags: ${{ vars.DOCKERHUB_USERNAME }}/${{ matrix.container.image }}:${{ matrix.container.tag }},${{ vars.DOCKERHUB_USERNAME }}/${{ matrix.container.image }}:latest
+
+      - name: Test
+        uses: docker/build-push-action@v5
+        with:
+          context: .
+          file: ./dev/docker/examples/${{ matrix.container.file }}
+          push: false
+          tags: ${{ vars.DOCKERHUB_USERNAME }}/test-${{ matrix.container.image }}:${{ matrix.container.tag }}
 
   Release:
     if: startsWith(github.ref, 'refs/tags/')

README.md

@@ -211,7 +211,7 @@ If you want to build the ones included, then run:
 ```shell
 git clone --recurse-submodules https://github.com/aminya/setup-cpp
 cd ./setup-cpp
-docker build -f ./dev/docker/setup-cpp-ubuntu.dockerfile -t setup-cpp-ubuntu .
+docker build -f ./dev/docker/setup-cpp/setup-cpp-ubuntu.dockerfile -t setup-cpp-ubuntu-llvm:22.04-17 ./
 ```
 
 Where you should use the path to the dockerfile after `-f`.
@@ -219,7 +219,7 @@ Where you should use the path to the dockerfile after `-f`.
 After build, run the following to start an interactive shell in your container
 
 ```shell
-docker run -it setup-cpp
+docker run -it setup-cpp-ubuntu-llvm:22.04-17
 ```
 
 ### Inside Docker inside GitHub Actions

dev/docker/__tests__/arch-mingw.dockerfile

@@ -1,53 +0,0 @@
-## base image
-FROM archlinux:base-devel as setup-cpp-arch-mingw
-
-COPY "./dist/legacy" "/usr/lib/setup-cpp/"
-
-# install git
-RUN pacman -Syuu --noconfirm && \
-    pacman-db-upgrade && \
-    pacman -S --noconfirm --needed git
-# install yay
-RUN useradd -m -G nobody -s /bin/bash yay && passwd -d yay && echo "yay ALL=(ALL)  ALL" >> /etc/sudoers
-RUN git clone --depth 1 https://aur.archlinux.org/yay.git /opt/yay 
-WORKDIR /opt/yay
-RUN chown -R yay:root . && chmod -R 775 .
-USER yay
-WORKDIR /opt/yay
-RUN makepkg -si --noprogressbar --noconfirm
-## clean up
-USER root
-WORKDIR /
-RUN rm -rf /opt/yay
-
-RUN pacman -Syuu --noconfirm && \
-    pacman-db-upgrade && \
-    # install nodejs
-    pacman -S --noconfirm --needed nodejs npm && \
-    # install the compiler and tools
-    node /usr/lib/setup-cpp/setup-cpp.js \
-        --compiler mingw \
-        --cmake true \
-        --ninja true \
-        --task true \
-        --vcpkg true \
-        --python true \
-        --make true \
-        --cppcheck true \
-        --gcovr true \
-        --doxygen true \
-        --ccache true && \
-    # arch cleanup
-    pacman -Scc --noconfirm && \
-    rm -rf /var/cache/pacman/pkg/* && \
-    rm -rf /tmp/*
-
-ENTRYPOINT ["/bin/bash"]
-
-#### Cross Building (example)
-FROM setup-cpp-arch-mingw AS builder-mingw
-
-COPY ./dev/cpp_vcpkg_project /home/app
-WORKDIR /home/app
-RUN bash -c 'source ~/.cpprc \
-    && task build_cross_mingw'

dev/docker/ci/arch-llvm.dockerfile

@@ -27,20 +27,3 @@ RUN pacman -Syuu --noconfirm && \
     rm -rf /tmp/*
 
 ENTRYPOINT ["/bin/bash"]
-
-#### Building (example)
-FROM setup-cpp-arch AS builder
-
-COPY ./dev/cpp_vcpkg_project /home/app
-WORKDIR /home/app
-RUN bash -c 'source ~/.cpprc \
-    && task build'
-
-#### Running environment
-# use a fresh image as the runner
-FROM archlinux:base as runner
-
-# copy the built binaries and their runtime dependencies
-COPY --from=builder /home/app/build/my_exe/Release/ /home/app/
-WORKDIR /home/app/
-ENTRYPOINT ["./my_exe"]

dev/docker/ci/arch-mingw.dockerfile

@@ -0,0 +1,29 @@
+## base image
+FROM archlinux:base as setup-cpp-arch-mingw
+
+COPY "./dist/legacy" "/usr/lib/setup-cpp/"
+
+RUN pacman -Syuu --noconfirm && \
+    pacman-db-upgrade && \
+    # install nodejs
+    pacman -S --noconfirm --needed nodejs npm && \
+    
+    # install the compiler and tools
+    node /usr/lib/setup-cpp/setup-cpp.js \
+        --compiler mingw \
+        --cmake true \
+        --ninja true \
+        --task true \
+        --vcpkg true \
+        --python true \
+        --make true \
+        --cppcheck true \
+        --gcovr true \
+        --doxygen true \
+        --ccache true && \
+    # arch cleanup
+    pacman -Scc --noconfirm && \
+    rm -rf /var/cache/pacman/pkg/* && \
+    rm -rf /tmp/*
+
+ENTRYPOINT ["/bin/bash"]

dev/docker/ci/docker-ci.mjs

@@ -1,12 +1,10 @@
 import { readFile, writeFile } from "fs/promises"
 
 async function main() {
-  const dockerFiles = ["ubuntu", "arch", "fedora", "ubuntu-mingw", "arch-mingw", "fedora-mingw"]
+  const names = ["ubuntu-llvm", "arch-llvm", "fedora-llvm", "ubuntu-mingw", "arch-mingw", "fedora-mingw"]
   await Promise.all(
-    dockerFiles.map(async (dockerFile) => {
+    names.map(async (name) => {
-      const dockerFileContent = await readFile(`./dev/docker/setup-cpp-${dockerFile}.dockerfile`, "utf-8")
+      const dockerFileContent = await readFile(`./dev/docker/setup-cpp/setup-cpp-${name}.dockerfile`, "utf-8")
-      const builderExample = await readFile(`./dev/docker/${dockerFile}.dockerfile`, "utf-8")
-
       const modifiedDockerFile = dockerFileContent
         // load the externally built setup-cpp
         .replace(/FROM (.*)/g, `FROM $1\n\nCOPY "./dist/legacy" "/usr/lib/setup-cpp/"`)
@@ -14,11 +12,8 @@ async function main() {
         // remove the npm install line
         .replace(/# install setup-cpp\n\s*npm install -g setup-cpp.*/, "")
 
-      // concat the two files
+      // write the new file in dev/docker/ci
-      const newDockerFileContent = `${modifiedDockerFile}\n${builderExample}`
+      await writeFile(`./dev/docker/ci/${name}.dockerfile`, modifiedDockerFile)
-
-      // write the new file in dev/docker/__tests__
-      await writeFile(`./dev/docker/__tests__/${dockerFile}.dockerfile`, newDockerFileContent)
     }),
   )
 }

dev/docker/ci/fedora-llvm.dockerfile

@@ -24,20 +24,3 @@ RUN dnf -y install nodejs npm && \
     rm -rf /tmp/*
 
 ENTRYPOINT ["/bin/bash"]
-
-#### Building (example)
-FROM setup-cpp-fedora AS builder
-
-COPY ./dev/cpp_vcpkg_project /home/app
-WORKDIR /home/app
-RUN bash -c 'source ~/.cpprc \
-    && task build'
-
-#### Running environment
-# use a fresh image as the runner
-FROM fedora:40 as runner
-
-# copy the built binaries and their runtime dependencies
-COPY --from=builder /home/app/build/my_exe/Release/ /home/app/
-WORKDIR /home/app/
-ENTRYPOINT ["./my_exe"]

dev/docker/ci/fedora-mingw.dockerfile

@@ -25,11 +25,3 @@ RUN dnf -y install nodejs npm && \
     rm -rf /tmp/*
 
 ENTRYPOINT ["/bin/bash"]
-
-#### Cross Building (example)
-FROM setup-cpp-fedora-mingw AS builder-mingw
-
-COPY ./dev/cpp_vcpkg_project /home/app
-WORKDIR /home/app
-RUN bash -c 'source ~/.cpprc \
-    && task build_cross_mingw'

dev/docker/ci/ubuntu-llvm.dockerfile

@@ -30,20 +30,3 @@ RUN apt-get update -qq && \
     rm -rf /tmp/*
 
 ENTRYPOINT ["/bin/bash"]
-
-#### Building (example)
-FROM setup-cpp-ubuntu AS builder
-
-COPY ./dev/cpp_vcpkg_project /home/app
-WORKDIR /home/app
-RUN bash -c 'source ~/.cpprc \
-    && task build'
-
-#### Running environment
-# use a fresh image as the runner
-FROM ubuntu:22.04 as runner
-
-# copy the built binaries and their runtime dependencies
-COPY --from=builder /home/app/build/my_exe/Release/ /home/app/
-WORKDIR /home/app/
-ENTRYPOINT ["./my_exe"]

dev/docker/ci/ubuntu-mingw.dockerfile

@@ -31,11 +31,3 @@ RUN apt-get update -qq && \
     rm -rf /tmp/*
 
 ENTRYPOINT ["/bin/bash"]
-
-#### Cross Building (example)
-FROM setup-cpp-ubuntu-mingw AS builder-mingw
-
-COPY ./dev/cpp_vcpkg_project /home/app
-WORKDIR /home/app
-RUN bash -c 'source ~/.cpprc \
-    && task build_cross_mingw'

dev/docker/examples/arch-llvm.dockerfile

@@ -1,5 +1,5 @@
 #### Building (example)
-FROM setup-cpp-arch AS builder
+FROM aminya/setup-cpp-arch-llvm AS builder
 
 COPY ./dev/cpp_vcpkg_project /home/app
 WORKDIR /home/app

dev/docker/examples/arch-mingw.dockerfile

@@ -1,5 +1,5 @@
 #### Cross Building (example)
-FROM setup-cpp-arch-mingw AS builder-mingw
+FROM aminya/setup-cpp-arch-mingw AS builder-mingw
 
 COPY ./dev/cpp_vcpkg_project /home/app
 WORKDIR /home/app

dev/docker/examples/fedora-llvm.dockerfile

@@ -1,5 +1,5 @@
 #### Building (example)
-FROM setup-cpp-fedora AS builder
+FROM aminya/setup-cpp-fedora-llvm AS builder
 
 COPY ./dev/cpp_vcpkg_project /home/app
 WORKDIR /home/app

dev/docker/examples/fedora-mingw.dockerfile

@@ -1,5 +1,5 @@
 #### Cross Building (example)
-FROM setup-cpp-fedora-mingw AS builder-mingw
+FROM aminya/setup-cpp-fedora-mingw AS builder-mingw
 
 COPY ./dev/cpp_vcpkg_project /home/app
 WORKDIR /home/app

dev/docker/examples/ubuntu-llvm.dockerfile

@@ -1,5 +1,5 @@
 #### Building (example)
-FROM setup-cpp-ubuntu AS builder
+FROM aminya/setup-cpp-ubuntu-llvm AS builder
 
 COPY ./dev/cpp_vcpkg_project /home/app
 WORKDIR /home/app

dev/docker/examples/ubuntu-mingw.dockerfile

@@ -1,5 +1,5 @@
 #### Cross Building (example)
-FROM setup-cpp-ubuntu-mingw AS builder-mingw
+FROM aminya/setup-cpp-ubuntu-mingw AS builder-mingw
 
 COPY ./dev/cpp_vcpkg_project /home/app
 WORKDIR /home/app

package.json

@@ -55,19 +55,7 @@
     "test.lint.eslint": "eslint **/*.{ts,tsx,js,jsx,cjs,mjs,json,yaml} --no-error-on-unmatched-pattern --cache --cache-location ./.cache/eslint/",
     "test.lint.prettier": "prettier . --check",
     "test": "jest --runInBand --forceExit --coverage",
-    "build.docker_tests": "node ./dev/docker/__tests__/generate-docker-tests.mjs",
+    "build.docker-ci": "node ./dev/docker/ci/docker-ci.mjs"
-    "build.docker.arch": "pnpm build.docker_tests && docker build -f ./dev/docker/__tests__/arch.dockerfile -t setup-cpp:arch .",
-    "build.docker.fedora": "pnpm build.docker_tests && docker build -f ./dev/docker/__tests__/fedora.dockerfile -t setup-cpp:fedora .",
-    "build.docker.ubuntu": "pnpm build.docker_tests && docker build -f ./dev/docker/__tests__/ubuntu.dockerfile -t setup-cpp:ubuntu .",
-    "build.docker.arch.mingw": "pnpm build.docker_tests && docker build -f ./dev/docker/__tests__/arch-mingw.dockerfile -t setup-cpp:arch-mingw .",
-    "build.docker.fedora.mingw": "pnpm build.docker_tests && docker build -f ./dev/docker/__tests__/fedora-mingw.dockerfile -t setup-cpp:fedora-mingw .",
-    "build.docker.ubuntu.mingw": "pnpm build.docker_tests && docker build -f ./dev/docker/__tests__/ubuntu-mingw.dockerfile -t setup-cpp:ubuntu-mingw .",
-    "test.docker.arch": "pnpm build.docker.arch && container-structure-test test --image setup-cpp:arch --config ./dev/docker/__tests__/arch.yml",
-    "test.docker.fedora": "pnpm build.docker.fedora && container-structure-test test --image setup-cpp:fedora --config ./dev/docker/__tests__/fedora.yml",
-    "test.docker.ubuntu": "pnpm build.docker.ubuntu && container-structure-test test --image setup-cpp:ubuntu --config ./dev/docker/__tests__/ubuntu.yml",
-    "test.docker.arch.mingw": "pnpm build.docker.arch.mingw && container-structure-test test --image setup-cpp:arch-mingw --config ./dev/docker/__tests__/arch-mingw.yml",
-    "test.docker.fedora.mingw": "pnpm build.docker.fedora.mingw && container-structure-test test --image setup-cpp:fedora-mingw --config ./dev/docker/__tests__/fedora-mingw.yml",
-    "test.docker.ubuntu.mingw": "pnpm build.docker.ubuntu.mingw && container-structure-test test --image setup-cpp:ubuntu-mingw --config ./dev/docker/__tests__/ubuntu-mingw.yml"
   },
   "prettier": "prettier-config-atomic",
   "devDependencies": {

tsconfig.json

@@ -33,7 +33,7 @@
     "./src",
     "dev/scripts",
     "packages/untildify-user/untildify.ts",
-    "dev/docker/__tests__/generate-docker-tests.mjs",
+    "dev/docker/ci/docker-ci.mjs",
     "./jest.config.ts"
   ]
 }