fix: clean up the syncVersions code

This commit is contained in:
Amin Yahyaabadi 2023-01-17 21:00:42 -08:00
parent e550b921dd
commit b0d65272c0
5 changed files with 16 additions and 8 deletions

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

File diff suppressed because one or more lines are too long

View File

@ -29,17 +29,25 @@ export function isDefault(version: string | undefined, name: string) {
return version === "true" || (version === undefined && name in DefaultVersions) return version === "true" || (version === undefined && name in DefaultVersions)
} }
/**
* Sync the versions for the given inputs
*
* If the return is false, it means that versions don't match the target version
*/
export function syncVersions(opts: Opts, tools: Inputs[]): boolean { export function syncVersions(opts: Opts, tools: Inputs[]): boolean {
const toolsInUse = tools.filter((tool) => opts[tool] !== undefined) const toolsInUse = tools.filter((tool) => opts[tool] !== undefined)
const toolsNonDefaultVersion = toolsInUse.filter((tool) => !isDefault(opts[tool], tool)) const toolsNonDefaultVersion = toolsInUse.filter((tool) => !isDefault(opts[tool], tool))
const targetVersion = toolsNonDefaultVersion.length ? opts[toolsNonDefaultVersion[0]] : "true" const targetVersion = toolsNonDefaultVersion.length >= 1 ? opts[toolsNonDefaultVersion[0]] : "true"
// return false if any explicit versions don't match the target version if (toolsNonDefaultVersion.some((tool) => opts[tool] !== targetVersion)) {
if (toolsNonDefaultVersion.findIndex((tool) => opts[tool] !== targetVersion) !== -1) { // error if any explicit versions don't match the target version
return false return false
} }
toolsInUse.forEach((tool) => (opts[tool] = targetVersion)) toolsInUse.forEach((tool) => {
opts[tool] = targetVersion
})
return true return true
} }