From abb5917b833e669065bc521765a6b0de7defadb5 Mon Sep 17 00:00:00 2001 From: Amin Yahyaabadi Date: Fri, 17 Sep 2021 05:06:14 -0500 Subject: [PATCH] test: do not spawn OpenCppCoverage due to its non-zero exit codes --- .../__tests__/opencppcoverage.test.ts | 2 +- src/utils/tests/test-helpers.ts | 12 +++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/opencppcoverage/__tests__/opencppcoverage.test.ts b/src/opencppcoverage/__tests__/opencppcoverage.test.ts index 5c341280..779aad7e 100644 --- a/src/opencppcoverage/__tests__/opencppcoverage.test.ts +++ b/src/opencppcoverage/__tests__/opencppcoverage.test.ts @@ -9,6 +9,6 @@ describe("setup-OpenCppCoverage", () => { } await setupOpencppcoverage("", "", process.arch) - await testBin("OpenCppCoverage") + await testBin("OpenCppCoverage", null) // OpenCppCoverage exits with non-zero even with --help }) }) diff --git a/src/utils/tests/test-helpers.ts b/src/utils/tests/test-helpers.ts index 02548c89..f0ff9c65 100644 --- a/src/utils/tests/test-helpers.ts +++ b/src/utils/tests/test-helpers.ts @@ -36,7 +36,11 @@ export async function cleanupTmpDir(testName: string) { } } -export async function testBin(name: string, args: string[] = ["--version"], binDir: string | undefined = undefined) { +export async function testBin( + name: string, + args: string[] | null = ["--version"], + binDir: string | undefined = undefined +) { let bin = name if (typeof binDir === "string") { expect(binDir).toBeDefined() @@ -44,8 +48,10 @@ export async function testBin(name: string, args: string[] = ["--version"], binD bin = join(binDir, addBinExtension(name)) } - const status = await exec(escape(bin) as string, args) - expect(status).toBe(0) + if (args !== null) { + const status = await exec(escape(bin) as string, args) + expect(status).toBe(0) + } expect(await io.which(name, true)).toBe(bin) }