Merge pull request #99 from aminya/esm

cspell.config.yaml

@@ -75,6 +75,7 @@ words:
   - tsbuildinfo
   - ucrt
   - untildify
+  - upleveled
   - vbatts
   - vcpkg
   - vcvarsall

dev/cpp_vcpkg_project

@@ -1 +1 @@
-Subproject commit 467e5baf5e5caff2a6462581f7c2b0ca62d9af8c
+Subproject commit c30589196b2c59a3055dfc7c24244b4a1f48b081

dev/scripts/pack-exe.ts

@@ -1,5 +1,5 @@
 /* eslint-disable import/no-extraneous-dependencies */
-import { node } from "execa"
+import { execaNode } from "execa"
 
 function getPlatformName() {
   switch (process.platform) {
@@ -27,7 +27,7 @@ function main() {
 
   return Promise.all(
     exes.map((exe) =>
-      node("./node_modules/caxa/build/index.mjs", [
+      execaNode("./node_modules/caxa/build/index.mjs", [
         "--input",
         "./dist/node16",
         "--output",

package.json

@@ -31,8 +31,8 @@
     "build.docker.arch": "pnpm build && docker build -f ./dev/docker/arch_node.dockerfile -t setup-cpp:arch .",
     "build.docker.fedora": "pnpm build && docker build -f ./dev/docker/fedora_node.dockerfile -t setup-cpp:fedora .",
     "build.docker.ubuntu": "pnpm build && docker build -f ./dev/docker/ubuntu_node.dockerfile -t setup-cpp:ubuntu .",
-    "build.parcel": "cross-env NODE_ENV=production parcel build",
+    "build.parcel": "cross-env NODE_ENV=production parcel build && babel ./dist --out-dir dist --plugins @upleveled/babel-plugin-remove-node-prefix --compact --no-babelrc --source-maps true",
-    "bump": "ncu -u -x execa,numerous,path-exists && pnpm update",
+    "bump": "ncu -u -x numerous && pnpm update",
     "clean": "shx rm -rf .parcel-cache dist exe",
     "copy.matchers": "shx cp ./src/gcc/gcc_matcher.json ./dist/node12/ && shx cp ./src/msvc/msvc_matcher.json ./dist/node12/ && shx cp ./src/python/python_matcher.json ./dist/node12/ && shx cp ./src/llvm/llvm_matcher.json ./dist/node12/ && shx cp ./dist/node12/*.json ./dist/node16/",
     "dev": "cross-env NODE_ENV=development parcel watch",
@@ -64,15 +64,17 @@
     "@actions/exec": "^1.1.1",
     "@actions/io": "^1.1.3",
     "@actions/tool-cache": "^2.0.1",
+    "@babel/cli": "^7.21.0",
     "@types/cross-spawn": "^6.0.2",
     "@types/eslint": "^8.37.0",
     "@types/jest": "^29.5.1",
     "@types/mri": "^1.1.1",
-    "@types/node": "^18.15.13",
+    "@types/node": "^18.16.0",
     "@types/npmcli__ci-detect": "^2.0.0",
     "@types/prettier": "2.7.2",
     "@types/semver": "^7.3.13",
     "@types/which": "^3.0.0",
+    "@upleveled/babel-plugin-remove-node-prefix": "github:aminya/babel-plugin-remove-node-prefix#95fcbd92405b99a6eece48c493548996f12e6519",
     "admina": "^0.1.3",
     "caxa": "^3.0.1",
     "ci-info": "^3.8.0",
@@ -86,7 +88,8 @@
     "eslint": "^8.39.0",
     "eslint-config-atomic": "^1.18.3",
     "exec-powershell": "workspace:*",
-    "execa": "^5.1.1",
+    "execa": "^7.1.1",
+    "fast-glob": "^3.2.12",
     "gen-readme": "^1.6.0",
     "is-url-online": "^1.5.0",
     "jest": "^29.5.0",
@@ -96,14 +99,14 @@
     "npm-run-all2": "^6.0.5",
     "numerous": "1.0.3",
     "parcel": "2.8.3",
-    "path-exists": "^4.0.0",
+    "path-exists": "^5.0.0",
     "patha": "^0.4.1",
-    "prettier": "2.7.1",
+    "prettier": "2.8.8",
     "prettier-config-atomic": "^3.1.0",
     "quote-unquote": "^1.0.0",
     "readme-md-generator": "^1.0.0",
     "retry-as-promised": "^7.0.4",
-    "semver": "7.3.8",
+    "semver": "7.5.0",
     "setup-python": "github:actions/setup-python#v4.6.0",
     "shx": "0.3.4",
     "terser-config-atomic": "^0.1.1",
@@ -144,20 +147,6 @@
     "patha": "patha/dist/index.node.mjs"
   },
   "main.actions": "./dist/node16/setup-cpp.js",
-  "pnpm": {
-    "overrides": {
-      "semver": "7.3.8",
-      "eslint": "^8.28.0",
-      "prettier": "2.7.1",
-      "core-js": "*",
-      "babel-eslint": "npm:@babel/eslint-parser"
-    },
-    "peerDependencyRules": {
-      "allowedVersions": {
-        "eslint": "*"
-      }
-    }
-  },
   "targets": {
     "main": {
       "context": "node",

packages/exec-powershell/README.md

@@ -38,7 +38,7 @@ Execute a powershell command.
 
 - command (`string`) - The powershell command to execute
 - startupFlags (`string[]`) - The optional startup flags to be passed to powershell. Defaults to `["-NoProfile", "-NoLogo", "-NonInteractive"]`. This means that the Powershell profile is not sourced first.
-- execOptions (`execa.SyncOptions`) - The options passed to `execa`. Defaults to `{ stdio: "inherit" }`
+- execOptions (`execaSyncOptions`) - The options passed to `execa`. Defaults to `{ stdio: "inherit" }`
 
 **returns:** execa.ExecaSyncReturnValue<string>
 

packages/exec-powershell/package.json

@@ -11,7 +11,7 @@
     "build": "tsc"
   },
   "dependencies": {
-    "execa": "^5.1.1",
+    "execa": "^7.1.1",
     "which": "^2.0.2"
   },
   "devDependencies": {

packages/exec-powershell/src/index.ts

@@ -1,4 +1,4 @@
-import execa from "execa"
+import * as execa from "execa"
 import which from "which"
 
 /** The cached powershell path */
@@ -19,7 +19,7 @@ export function execPowershell(
   startupFlags: string[] = ["-NoProfile", "-NoLogo", "-NonInteractive"],
   execOptions: execa.Options = { stdio: "inherit" }
 ): execa.ExecaChildProcess<string> {
-  return execa(getPowerShell(), [...startupFlags, "-c", command], execOptions)
+  return execa.execa(getPowerShell(), [...startupFlags, "-c", command], execOptions)
 }
 
 /**
@@ -37,7 +37,7 @@ export function execPowershellSync(
   startupFlags: string[] = ["-NoProfile", "-NoLogo", "-NonInteractive"],
   execOptions: execa.SyncOptions = { stdio: "inherit" }
 ): execa.ExecaSyncReturnValue<string> {
-  return execa.sync(getPowerShell(), [...startupFlags, "-c", command], execOptions)
+  return execa.execaSync(getPowerShell(), [...startupFlags, "-c", command], execOptions)
 }
 
 /**

src/brew/brew.ts

@@ -1,4 +1,4 @@
-import execa from "execa"
+import { execaSync } from "execa"
 import { dirname } from "patha"
 import which from "which"
 import { tmpdir } from "os"
@@ -28,7 +28,7 @@ export async function setupBrew(_version: string, _setupDir: string, _arch: stri
   const brewTempDirectory = path.join(tmpdir(), "setup-cpp", "brew")
   await mkdirP(brewTempDirectory)
 
-  execa.sync("curl", ["-LJO", "https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh"], {
+  execaSync("curl", ["-LJO", "https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh"], {
     cwd: brewTempDirectory,
   })
   const installSh = join(brewTempDirectory, "install.sh")
@@ -39,7 +39,7 @@ export async function setupBrew(_version: string, _setupDir: string, _arch: stri
     installShContent.replace("#!/bin/bash", "")
   }
 
-  execa.sync("/bin/bash", [installSh], {
+  execaSync("/bin/bash", [installSh], {
     stdio: "inherit",
     env: {
       NONINTERACTIVE: "1",

src/chocolatey/chocolatey.ts

@@ -1,7 +1,6 @@
 /* eslint-disable require-atomic-updates */
-import execa from "execa"
+import { execaSync } from "execa"
-
+import { pathExists } from "path-exists"
-import pathExists from "path-exists"
 import { dirname } from "patha"
 import which from "which"
 import { addPath } from "../utils/env/addEnv"
@@ -40,7 +39,7 @@ export async function setupChocolatey(
   }
 
   // https://docs.chocolatey.org/en-us/choco/setup#install-with-cmd.exe
-  execa.sync(
+  execaSync(
     powershell,
     [
       "-NoProfile",

src/doxygen/doxygen.ts

@@ -14,7 +14,7 @@ import { isArch } from "../utils/env/isArch"
 import { hasDnf } from "../utils/env/hasDnf"
 import { setupDnfPack } from "../utils/setup/setupDnfPack"
 import { isUbuntu } from "../utils/env/isUbuntu"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 import retry from "retry-as-promised"
 
 /** Get the platform data for cmake */

src/gcc/__tests__/gcc.test.ts

@@ -2,7 +2,7 @@ import { cleanupTmpDir, setupTmpDir, testBin } from "../../utils/tests/test-help
 import { setupGcc } from "../gcc"
 import { getVersion } from "../../versions/versions"
 import { join, addExeExt } from "patha"
-import execa from "execa"
+import { execaSync } from "execa"
 import { chmodSync } from "fs"
 import { ubuntuVersion } from "../../utils/env/ubuntu_version"
 
@@ -29,11 +29,11 @@ describe("setup-gcc", () => {
     // test compilation
     const file = join(__dirname, "main.cpp")
     const main_exe = join(__dirname, addExeExt("main"))
-    execa.sync("g++", [file, "-o", main_exe], { cwd: __dirname })
+    execaSync("g++", [file, "-o", main_exe], { cwd: __dirname })
     if (process.platform !== "win32") {
       chmodSync(main_exe, "755")
     }
-    execa.sync(main_exe, { cwd: __dirname, stdio: "inherit" })
+    execaSync(main_exe, { cwd: __dirname, stdio: "inherit" })
   })
 
   afterAll(async () => {

src/gcc/gcc.ts

@@ -16,7 +16,7 @@ import { isArch } from "../utils/env/isArch"
 import { isUbuntu } from "../utils/env/isUbuntu"
 import { hasDnf } from "../utils/env/hasDnf"
 import { setupDnfPack } from "../utils/setup/setupDnfPack"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 
 interface MingwInfo {
   releaseName: string

src/kcov/kcov.ts

@@ -1,4 +1,4 @@
-import execa from "execa"
+import { execa } from "execa"
 import { join, addExeExt } from "patha"
 import which from "which"
 import { setupCmake } from "../cmake/cmake"

src/llvm/__tests__/llvm.test.ts

@@ -3,7 +3,7 @@ import { getSpecificVersionAndUrl } from "../../utils/setup/version"
 import { isUrlOnline } from "is-url-online"
 import { setupTmpDir, testBin } from "../../utils/tests/test-helpers"
 import { GITHUB_ACTIONS } from "ci-info"
-import execa from "execa"
+import { execaSync } from "execa"
 import path, { addExeExt } from "patha"
 import { chmodSync } from "fs"
 import { getVersion } from "../../versions/versions"
@@ -92,11 +92,11 @@ describe("setup-llvm", () => {
     // test compilation
     const file = path.join(__dirname, "main.cpp")
     const main_exe = path.join(__dirname, addExeExt("main"))
-    execa.sync("clang++", [file, "-o", main_exe], { cwd: __dirname })
+    execaSync("clang++", [file, "-o", main_exe], { cwd: __dirname })
     if (process.platform !== "win32") {
       chmodSync(main_exe, "755")
     }
-    execa.sync(main_exe, { cwd: __dirname, stdio: "inherit" })
+    execaSync(main_exe, { cwd: __dirname, stdio: "inherit" })
   })
 
   it("should find llvm in the cache", async () => {

src/llvm/llvm.ts

@@ -14,7 +14,7 @@ import { getVersion } from "../versions/versions"
 import { isUbuntu } from "../utils/env/isUbuntu"
 import { getLLVMPackageInfo } from "./llvm_url"
 import { ubuntuVersion } from "../utils/env/ubuntu_version"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 import { ExecaReturnValue } from "execa"
 
 export async function setupLLVM(version: string, setupDir: string, arch: string): Promise<InstallationInfo> {

src/msvc/msvc.ts

@@ -7,7 +7,7 @@ import { GITHUB_ACTIONS } from "ci-info"
 import { join } from "patha"
 
 import { error, info, warning } from "ci-log"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 
 type MSVCVersion = "2022" | "17.0" | "2019" | "16.0" | "2017" | "15.0" | "2015" | "14.0" | "2013" | "12.0" | string
 

src/python/actions_python.ts

@@ -7,7 +7,7 @@ import { join } from "patha"
 import { GITHUB_ACTIONS } from "ci-info"
 import { isCacheFeatureAvailable, IS_MAC } from "setup-python/src/utils"
 import { getCacheDistributor } from "setup-python/src/cache-distributions/cache-factory"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 
 function isPyPyVersion(versionSpec: string) {
   return versionSpec.startsWith("pypy")

src/python/python.ts

@@ -16,7 +16,7 @@ import { getExecOutput } from "@actions/exec"
 import { isBinUptoDate } from "../utils/setup/version"
 import { getVersion } from "../versions/versions"
 import assert from "assert"
-import execa from "execa"
+import { execaSync } from "execa"
 import { unique } from "../utils/std"
 
 export async function setupPython(version: string, setupDir: string, arch: string) {
@@ -71,12 +71,12 @@ export async function setupPythonViaSystem(
       } else if (isUbuntu()) {
         installInfo = await setupAptPack([{ name: "python3", version }, { name: "python3-pip" }])
       } else {
-        throw new Error(`Unsupported linux distributions`)
+        throw new Error("Unsupported linux distributions")
       }
       return installInfo
     }
     default: {
-      throw new Error(`Unsupported platform`)
+      throw new Error("Unsupported platform")
     }
   }
 }
@@ -109,7 +109,7 @@ export async function setupPythonAndPip(): Promise<string> {
   if (process.platform === "win32") {
     // downgrade pip on Windows
     // https://github.com/pypa/pip/issues/10875#issuecomment-1030293005
-    execa.sync(foundPython, ["-m", "pip", "install", "-U", "pip==21.3.1"], { stdio: "inherit" })
+    execaSync(foundPython, ["-m", "pip", "install", "-U", "pip==21.3.1"], { stdio: "inherit" })
   } else if (process.platform === "linux") {
     // ensure that pip is installed on Linux (happens when python is found but pip not installed)
     if (isArch()) {
@@ -122,7 +122,7 @@ export async function setupPythonAndPip(): Promise<string> {
   }
 
   // install wheel (required for Conan, Meson, etc.)
-  execa.sync(foundPython, ["-m", "pip", "install", "-U", "wheel"], { stdio: "inherit" })
+  execaSync(foundPython, ["-m", "pip", "install", "-U", "wheel"], { stdio: "inherit" })
 
   return foundPython
 }

src/utils/env/addEnv.ts

@@ -8,7 +8,7 @@ import { delimiter } from "path"
 import escapeSpace from "escape-path-with-spaces"
 import { giveUserAccess } from "user-access"
 import escapeQuote from "escape-quotes"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 
 /**
  * Add an environment variable.
@@ -69,7 +69,7 @@ async function addEnvSystem(name: string, valGiven: string | undefined) {
   const val = valGiven ?? ""
   switch (process.platform) {
     case "win32": {
-      // We do not use `execa.sync(`setx PATH "${path};%PATH%"`)` because of its character limit
+      // We do not use `execaSync(`setx PATH "${path};%PATH%"`)` because of its character limit
       await execPowershell(`[Environment]::SetEnvironmentVariable('${name}', '${val}', "User")`)
       info(`${name}='${val}' was set in the environment.`)
       return
@@ -91,7 +91,7 @@ async function addEnvSystem(name: string, valGiven: string | undefined) {
 async function addPathSystem(path: string) {
   switch (process.platform) {
     case "win32": {
-      // We do not use `execa.sync(`setx PATH "${path};%PATH%"`)` because of its character limit and also because %PATH% is different for user and system
+      // We do not use `execaSync(`setx PATH "${path};%PATH%"`)` because of its character limit and also because %PATH% is different for user and system
       await execPowershell(
         `$USER_PATH=([Environment]::GetEnvironmentVariable("PATH", "User")); [Environment]::SetEnvironmentVariable("PATH", "${path};$USER_PATH", "User")`
       )

src/utils/setup/extract.ts

@@ -1,4 +1,4 @@
-import execa from "execa"
+import { execa } from "execa"
 import { mkdirP } from "@actions/io"
 import which from "which"
 import { setupSevenZip } from "../../sevenzip/sevenzip"

src/utils/setup/setupAptPack.ts

@@ -5,10 +5,10 @@ import { info } from "@actions/core"
 import { GITHUB_ACTIONS } from "ci-info"
 import { addEnv, cpprc_path, setupCppInProfile } from "../env/addEnv"
 import which from "which"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 import { promises as fsPromises } from "fs"
 const { appendFile } = fsPromises
-import execa from "execa"
+import { execa } from "execa"
 import escapeRegex from "escape-string-regexp"
 
 let didUpdate: boolean = false

src/utils/setup/setupBin.ts

@@ -11,7 +11,7 @@ import { isArch } from "../env/isArch"
 import { hasDnf } from "../env/hasDnf"
 import { setupDnfPack } from "./setupDnfPack"
 import { isUbuntu } from "../env/isUbuntu"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 import retry from "retry-as-promised"
 
 /** A type that describes a package */

src/utils/setup/setupBrewPack.ts

@@ -1,6 +1,6 @@
 /* eslint-disable require-atomic-updates */
 import { info } from "@actions/core"
-import execa from "execa"
+import { execaSync } from "execa"
 import { join } from "patha"
 import which from "which"
 import { getBrewPath, setupBrew } from "../../brew/brew"
@@ -24,7 +24,7 @@ export async function setupBrewPack(
   const binDir = getBrewPath()
 
   // brew is not thread-safe
-  execa.sync(
+  execaSync(
     join(binDir, "brew"),
     ["install", version !== undefined && version !== "" ? `${name}@${version}` : name, ...extraArgs],
     {

src/utils/setup/setupChocoPack.ts

@@ -3,7 +3,7 @@ import { addPath } from "../env/addEnv"
 import which from "which"
 import { setupChocolatey } from "../../chocolatey/chocolatey"
 import { InstallationInfo } from "./setupBin"
-import execa from "execa"
+import { execaSync } from "execa"
 import { info } from "@actions/core"
 import { notice } from "ci-log"
 
@@ -27,14 +27,14 @@ export async function setupChocoPack(name: string, version?: string, args: strin
   env.PATH = PATH
 
   if (version !== undefined && version !== "") {
-    execa.sync("choco", ["install", "-y", name, `--version=${version}`, ...args], {
+    execaSync("choco", ["install", "-y", name, `--version=${version}`, ...args], {
       env,
       extendEnv: false,
       stdio: "inherit",
     })
   } else {
     try {
-      execa.sync("choco", ["install", "-y", name, ...args], { env, extendEnv: false, stdio: "inherit" })
+      execaSync("choco", ["install", "-y", name, ...args], { env, extendEnv: false, stdio: "inherit" })
     } catch (err) {
       // if the package requires a reboot, downgrade the error to a notice
       if ((err as Error).message.includes("exit code 3010")) {

src/utils/setup/setupPipPack.ts

@@ -1,13 +1,12 @@
 /* eslint-disable require-atomic-updates */
-import execa from "execa"
 import { info } from "@actions/core"
-import { addPythonBaseExecPrefix, setupPythonAndPip } from "../../python/python"
+import { execaSync } from "execa"
-import { InstallationInfo } from "./setupBin"
+import { pathExists } from "path-exists"
-
 import { addExeExt, dirname, join } from "patha"
-import { addPath } from "../env/addEnv"
 import which from "which"
-import pathExists from "path-exists"
+import { addPythonBaseExecPrefix, setupPythonAndPip } from "../../python/python"
+import { addPath } from "../env/addEnv"
+import { InstallationInfo } from "./setupBin"
 
 let python: string | undefined
 let binDirs: string[] | undefined
@@ -20,7 +19,7 @@ export async function setupPipPack(name: string, version?: string): Promise<Inst
     python = await setupPythonAndPip()
   }
 
-  execa.sync(python, ["-m", "pip", "install", version !== undefined && version !== "" ? `${name}==${version}` : name], {
+  execaSync(python, ["-m", "pip", "install", version !== undefined && version !== "" ? `${name}==${version}` : name], {
     stdio: "inherit",
   })
 

src/utils/tests/test-helpers.ts

@@ -4,7 +4,7 @@ import * as path from "patha"
 import { addExeExt, join } from "patha"
 import spawn from "cross-spawn"
 
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 
 export async function setupTmpDir(testName: string) {
   const tempDirectory = path.join(tmpdir(), "setup cpp temp", testName)

src/vcpkg/vcpkg.ts

@@ -1,18 +1,17 @@
-import execa from "execa"
+import { execaSync } from "execa"
-
+import { notice } from "ci-log"
-import { dirname, join, addShExt, addShRelativePrefix } from "patha"
+import { pathExists } from "path-exists"
+import { addShExt, addShRelativePrefix, dirname, join } from "patha"
+import { giveUserAccess } from "user-access"
 import which from "which"
 import { addPath } from "../utils/env/addEnv"
-import { notice } from "ci-log"
-import { setupAptPack } from "../utils/setup/setupAptPack"
-import { setupPacmanPack } from "../utils/setup/setupPacmanPack"
-import { InstallationInfo } from "../utils/setup/setupBin"
-import { isArch } from "../utils/env/isArch"
 import { hasDnf } from "../utils/env/hasDnf"
-import { setupDnfPack } from "../utils/setup/setupDnfPack"
+import { isArch } from "../utils/env/isArch"
 import { isUbuntu } from "../utils/env/isUbuntu"
-import { giveUserAccess } from "user-access"
+import { setupAptPack } from "../utils/setup/setupAptPack"
-import pathExists from "path-exists"
+import { InstallationInfo } from "../utils/setup/setupBin"
+import { setupDnfPack } from "../utils/setup/setupDnfPack"
+import { setupPacmanPack } from "../utils/setup/setupPacmanPack"
 
 let hasVCPKG = false
 
@@ -48,12 +47,12 @@ export async function setupVcpkg(_version: string, setupDir: string, _arch: stri
     }
 
     if (!(await pathExists(join(setupDir, addShExt("bootstrap-vcpkg", ".bat"))))) {
-      execa.sync("git", ["clone", "https://github.com/microsoft/vcpkg"], { cwd: dirname(setupDir), stdio: "inherit" })
+      execaSync("git", ["clone", "https://github.com/microsoft/vcpkg"], { cwd: dirname(setupDir), stdio: "inherit" })
     } else {
       notice(`Vcpkg folder already exists at ${setupDir}. This might mean that ~/vcpkg is restored from the cache.`)
     }
 
-    execa.sync(addShExt(addShRelativePrefix("bootstrap-vcpkg"), ".bat"), {
+    execaSync(addShExt(addShRelativePrefix("bootstrap-vcpkg"), ".bat"), {
       cwd: setupDir,
       shell: true,
       stdio: "inherit",

src/vcvarsall/vcvarsall.ts

@@ -3,7 +3,7 @@
 import { setupMSVCDevCmd } from "msvc-dev-cmd/lib.js"
 import { addEnv } from "../utils/env/addEnv"
 import { info } from "ci-log"
-import pathExists from "path-exists"
+import { pathExists } from "path-exists"
 
 function getArch(arch: string): string {
   switch (arch) {