fix: fix checking of a pip package existence

packages/setup-apt/src/install.ts

@@ -68,6 +68,7 @@ const retryErrors = [
  * ```
  */
 export async function installAptPack(packages: AptPackage[], update = false): Promise<InstallationInfo> {
+  try {
     const apt: string = getApt()
 
     for (const { name, version } of packages) {
@@ -117,6 +118,10 @@ export async function installAptPack(packages: AptPackage[], update = false): Pr
     }
 
     return { binDir: "/usr/bin/" }
+  } catch (err) {
+    const msg = err instanceof Error ? `${err.message}\n${err.stack}` : String(err)
+    throw new Error(`Failed to install apt packages: ${msg}`)
+  }
 }
 
 async function addRepositories(apt: string, packages: AptPackage[]) {

src/utils/setup/setupPipPack.ts

@@ -55,14 +55,16 @@ export async function setupPipPackWithPython(
 
   // if upgrade is not requested, check if the package is already installed, and return if it is
   if (!upgrade) {
-    const installed = await pipPackageIsInstalled(givenPython, pip, name)
+    const installed = isPipx
+      ? await pipxPackageInstalled(givenPython, name)
+      : await pipPackageIsInstalled(givenPython, name)
     if (installed) {
       const binDir = await finishPipPackageInstall(givenPython, name)
       return { binDir }
     }
   }
 
-  const hasPackage = await pipHasPackage(givenPython, pip, name)
+  const hasPackage = await pipHasPackage(givenPython, name)
   if (hasPackage) {
     try {
       info(`Installing ${name} ${version ?? ""} via ${pip}`)
@@ -84,7 +86,8 @@ export async function setupPipPackWithPython(
         env,
       })
     } catch (err) {
-      info(`Failed to install ${name} via ${pip}: ${err}.`)
+      const msg = err instanceof Error ? `${err.message}\n${err.stack}` : String(err)
+      info(`Failed to install ${name} via ${pip}: ${msg}`)
       if ((await setupPipPackSystem(name)) === null) {
         throw new Error(`Failed to install ${name} via ${pip}: ${err}.`)
       }
@@ -168,6 +171,18 @@ async function getPython(): Promise<string> {
   return pythonBin
 }
 
+async function pipPackageIsInstalled(python: string, name: string) {
+  try {
+    const result = await execa(python, ["-m", "pip", "-qq", "show", name], {
+      stdio: "ignore",
+      reject: false,
+    })
+    return result.exitCode === 0
+  } catch {
+    return false
+  }
+}
+
 type PipxShowType = {
   venvs: Record<string, {
     metadata: {
@@ -180,10 +195,9 @@ type PipxShowType = {
   }>
 }
 
-async function pipPackageIsInstalled(python: string, pip: string, name: string) {
+async function pipxPackageInstalled(python: string, name: string) {
   try {
-    if (pip === "pipx") {
-      const result = await execa(python, ["-m", pip, "list", "--json"], {
+    const result = await execa(python, ["-m", "pipx", "list", "--json"], {
       stdio: "ignore",
       reject: false,
     })
@@ -191,7 +205,7 @@ async function pipPackageIsInstalled(python: string, pip: string, name: string)
       return false
     }
 
-      const pipxOut = JSON.parse(result.stdout as unknown as string) as PipxShowType
+    const pipxOut = JSON.parse(result.stdout) as PipxShowType
     // search among the venvs
     if (name in pipxOut.venvs) {
       return true
@@ -202,20 +216,14 @@ async function pipPackageIsInstalled(python: string, pip: string, name: string)
         return true
       }
     }
-    }
-
-    const result = await execa(python, ["-m", pip, "-qq", "show", name], {
-      stdio: "ignore",
-      reject: false,
-    })
-    return result.exitCode === 0
   } catch {
-    return false
+    // ignore
   }
+  return false
 }
 
-async function pipHasPackage(python: string, pip: string, name: string) {
-  const result = await execa(python, ["-m", pip, "-qq", "index", "versions", name], {
+async function pipHasPackage(python: string, name: string) {
+  const result = await execa(python, ["-m", "pip", "-qq", "index", "versions", name], {
     stdio: "ignore",
     reject: false,
   })