chore: make ubuntuVersion exception safe

src/main.ts

@@ -148,13 +148,7 @@ export async function main(args: string[]): Promise<number> {
 
   // installing the specified tools
 
-  let osVersion: number[] | null = null
+  const osVersion = await ubuntuVersion()
-  try {
-    // get the version if not already done
-    osVersion = await ubuntuVersion()
-  } catch (err) {
-    warning((err as Error).toString())
-  }
 
   // sync the version for the llvm tools
   if (!syncVersions(opts, ["llvm", "clangtidy", "clangformat"])) {

src/utils/env/ubuntu_version.ts

@@ -1,21 +1,28 @@
+import { warning } from "ci-log"
 import { getUbuntuVersion } from "ubuntu-version"
 import which from "which"
 import { setupAptPack } from "../setup/setupAptPack"
 import { isUbuntu } from "./isUbuntu"
 
 export async function ubuntuVersion(): Promise<number[] | null> {
-  if (isUbuntu()) {
+  try {
-    if (which.sync("lsb_release", { nothrow: true }) === null) {
+    if (isUbuntu()) {
-      await setupAptPack("lsb-release")
+      if (which.sync("lsb_release", { nothrow: true }) === null) {
-    }
+        await setupAptPack("lsb-release")
-    const versionSplitted = await getUbuntuVersion()
+      }
+      const versionSplitted = await getUbuntuVersion()
 
-    if (versionSplitted.length === 0) {
+      if (versionSplitted.length === 0) {
-      throw new Error("Failed to get the ubuntu major version.")
+        warning("Failed to get the ubuntu major version.")
-    }
+        return null
+      }
 
-    return versionSplitted
+      return versionSplitted
-  } else {
+    } else {
+      return null
+    }
+  } catch (err) {
+    warning((err as Error).toString())
     return null
   }
 }