From b4a12fa723b88d92fe4d6453c264116ced3349f6 Mon Sep 17 00:00:00 2001 From: Michael Bryan Date: Sat, 30 Sep 2017 17:06:30 +0800 Subject: [PATCH 1/3] Made sure google analytics isn't included when inspecting locally --- src/theme/index.hbs | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/theme/index.hbs b/src/theme/index.hbs index e115ee64..3be6a8ad 100644 --- a/src/theme/index.hbs +++ b/src/theme/index.hbs @@ -139,14 +139,20 @@ {{{livereload}}} {{#if google_analytics}} + {{/if}} From f2e56c887b9de8d70e631376064acb8b1eccd604 Mon Sep 17 00:00:00 2001 From: Michael Bryan Date: Sat, 30 Sep 2017 17:17:01 +0800 Subject: [PATCH 2/3] Got the logic around the wrong way --- src/theme/index.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/theme/index.hbs b/src/theme/index.hbs index 3be6a8ad..3bbcb20b 100644 --- a/src/theme/index.hbs +++ b/src/theme/index.hbs @@ -145,7 +145,7 @@ // make sure we don't activate google analytics if the developer is // inspecting the book locally... - if (localAddrs.indexOf(document.location.hostname) !== -1) { + if (localAddrs.indexOf(document.location.hostname) === -1) { (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) })(window,document,'script','https://www.google-analytics.com/analytics.js','ga'); From a554390aa271d3a003138862b39299d1136d2e37 Mon Sep 17 00:00:00 2001 From: Michael Bryan Date: Mon, 9 Oct 2017 09:52:22 +0800 Subject: [PATCH 3/3] Slightly cleaned up the google analytics tag (skip ci) --- src/theme/index.hbs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/theme/index.hbs b/src/theme/index.hbs index 3bbcb20b..ff8af727 100644 --- a/src/theme/index.hbs +++ b/src/theme/index.hbs @@ -146,7 +146,8 @@ // make sure we don't activate google analytics if the developer is // inspecting the book locally... if (localAddrs.indexOf(document.location.hostname) === -1) { - (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), + (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ + (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m) })(window,document,'script','https://www.google-analytics.com/analytics.js','ga');