Merge pull request #752 from mattico/icon-margin-padding

Icon button hit-test dead-space fix
This commit is contained in:
Matt Ickstadt 2018-07-30 19:19:31 -05:00 committed by GitHub
commit 8ba1830750
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions

View File

@ -381,7 +381,7 @@ function playpen_text(playpen) {
themePopup.addEventListener('focusout', function(e) { themePopup.addEventListener('focusout', function(e) {
// e.relatedTarget is null in Safari and Firefox on macOS (see workaround below) // e.relatedTarget is null in Safari and Firefox on macOS (see workaround below)
if (!!e.relatedTarget && !themePopup.contains(e.relatedTarget)) { if (!!e.relatedTarget && !themeToggleButton.contains(e.relatedTarget) && !themePopup.contains(e.relatedTarget)) {
hideThemes(); hideThemes();
} }
}); });

View File

@ -41,7 +41,7 @@ a > .hljs {
} }
#menu-bar i, #menu-bar .icon-button { #menu-bar i, #menu-bar .icon-button {
position: relative; position: relative;
margin: 0 8px; padding: 0 8px;
z-index: 10; z-index: 10;
line-height: 50px; line-height: 50px;
cursor: pointer; cursor: pointer;
@ -49,7 +49,7 @@ a > .hljs {
} }
@media only screen and (max-width: 420px) { @media only screen and (max-width: 420px) {
#menu-bar i, #menu-bar .icon-button { #menu-bar i, #menu-bar .icon-button {
margin: 0 5px; padding: 0 5px;
} }
} }
@ -71,8 +71,13 @@ html:not(.sidebar-visible) #menu-bar:not(:hover).folded > #menu-bar-sticky-conta
transform: translateY(-60px); transform: translateY(-60px);
} }
.left-buttons { margin: 0 5px; } .left-buttons {
.no-js .left-buttons { display: none; } display: flex;
margin: 0 5px;
}
.no-js .left-buttons {
display: none;
}
.menu-title { .menu-title {
display: inline-block; display: inline-block;
@ -374,6 +379,7 @@ a:hover {
.theme-popup { .theme-popup {
position: absolute; position: absolute;
left: 10px; left: 10px;
top: 50px;
z-index: 1000; z-index: 1000;
border-radius: 4px; border-radius: 4px;
font-size: 0.7em; font-size: 0.7em;