From abddd7c6f747856eba407ddc5fd981af1ae7022a Mon Sep 17 00:00:00 2001 From: "Carol (Nichols || Goulding)" Date: Thu, 20 Jun 2019 21:53:24 -0400 Subject: [PATCH] Use stdlib RangeBounds --- src/utils/mod.rs | 2 +- src/utils/string.rs | 62 +++++++++------------------------------------ 2 files changed, 13 insertions(+), 51 deletions(-) diff --git a/src/utils/mod.rs b/src/utils/mod.rs index 0f199fb7..37ea87b3 100644 --- a/src/utils/mod.rs +++ b/src/utils/mod.rs @@ -9,7 +9,7 @@ use pulldown_cmark::{html, CowStr, Event, Options, Parser, Tag}; use std::borrow::Cow; -pub use self::string::{take_lines, RangeArgument}; +pub use self::string::take_lines; /// Replaces multiple consecutive whitespace characters with a single space character. pub fn collapse_whitespace(text: &str) -> Cow<'_, str> { diff --git a/src/utils/string.rs b/src/utils/string.rs index e4566507..24a13f51 100644 --- a/src/utils/string.rs +++ b/src/utils/string.rs @@ -1,57 +1,19 @@ use itertools::Itertools; -use std::ops::{Range, RangeFrom, RangeFull, RangeTo}; - -// This trait is already contained in the standard lib, however it is unstable. -// TODO: Remove when the `collections_range` feature stabilises -// (https://github.com/rust-lang/rust/issues/30877) -pub trait RangeArgument { - fn start(&self) -> Option<&T>; - fn end(&self) -> Option<&T>; -} - -impl RangeArgument for RangeFull { - fn start(&self) -> Option<&T> { - None - } - fn end(&self) -> Option<&T> { - None - } -} - -impl RangeArgument for RangeFrom { - fn start(&self) -> Option<&T> { - Some(&self.start) - } - fn end(&self) -> Option<&T> { - None - } -} - -impl RangeArgument for RangeTo { - fn start(&self) -> Option<&T> { - None - } - fn end(&self) -> Option<&T> { - Some(&self.end) - } -} - -impl RangeArgument for Range { - fn start(&self) -> Option<&T> { - Some(&self.start) - } - fn end(&self) -> Option<&T> { - Some(&self.end) - } -} +use std::ops::Bound::{Excluded, Included, Unbounded}; +use std::ops::RangeBounds; /// Take a range of lines from a string. -pub fn take_lines>(s: &str, range: R) -> String { - let start = *range.start().unwrap_or(&0); +pub fn take_lines>(s: &str, range: R) -> String { + let start = match range.start_bound() { + Excluded(&n) => n + 1, + Included(&n) => n, + Unbounded => 0, + }; let mut lines = s.lines().skip(start); - match range.end() { - Some(&end) => lines.take(end.saturating_sub(start)).join("\n"), - None => lines.join("\n"), + match range.end_bound() { + Excluded(end) => lines.take(end.saturating_sub(start)).join("\n"), + Included(end) => lines.take((end + 1).saturating_sub(start)).join("\n"), + Unbounded => lines.join("\n"), } }