Merge pull request #1035 from andymac-2/line-numbers

Added line numbers to editable sections of code.
This commit is contained in:
Eric Huss 2019-09-26 10:53:32 -07:00 committed by GitHub
commit 73be1292ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 20 additions and 2 deletions

View File

@ -9,6 +9,7 @@ mathjax-support = true
[output.html.playpen] [output.html.playpen]
editable = true editable = true
line-numbers = true
[output.html.search] [output.html.search]
limit-results = 20 limit-results = 20

View File

@ -179,6 +179,7 @@ Available configuration options for the `[output.html.playpen]` table:
- **editable:** Allow editing the source code. Defaults to `false`. - **editable:** Allow editing the source code. Defaults to `false`.
- **copy-js:** Copy JavaScript files for the editor to the output directory. - **copy-js:** Copy JavaScript files for the editor to the output directory.
Defaults to `true`. Defaults to `true`.
- **line-numbers** Display line numbers on editable sections of code. Requires both `editable` and `copy-js` to be `true`. Defaults to `false`.
[Ace]: https://ace.c9.io/ [Ace]: https://ace.c9.io/
@ -228,6 +229,7 @@ git-repository-icon = "fa-github"
[output.html.playpen] [output.html.playpen]
editable = false editable = false
copy-js = true copy-js = true
line-numbers = false
[output.html.search] [output.html.search]
enable = true enable = true

View File

@ -479,6 +479,8 @@ pub struct Playpen {
/// Copy JavaScript files for the editor to the output directory? /// Copy JavaScript files for the editor to the output directory?
/// Default: `true`. /// Default: `true`.
pub copy_js: bool, pub copy_js: bool,
/// Display line numbers on playpen snippets
pub line_numbers: bool,
} }
impl Default for Playpen { impl Default for Playpen {
@ -486,6 +488,7 @@ impl Default for Playpen {
Playpen { Playpen {
editable: false, editable: false,
copy_js: true, copy_js: true,
line_numbers: false,
} }
} }
} }
@ -620,6 +623,7 @@ mod tests {
let playpen_should_be = Playpen { let playpen_should_be = Playpen {
editable: true, editable: true,
copy_js: true, copy_js: true,
line_numbers: false,
}; };
let html_should_be = HtmlConfig { let html_should_be = HtmlConfig {
curly_quotes: true, curly_quotes: true,

View File

@ -441,6 +441,9 @@ fn make_data(
if html_config.playpen.editable && html_config.playpen.copy_js { if html_config.playpen.editable && html_config.playpen.copy_js {
data.insert("playpen_js".to_owned(), json!(true)); data.insert("playpen_js".to_owned(), json!(true));
if html.playpen.line_numbers {
data.insert("playpen_line_numbers".to_owned(), json!(true));
}
} }
let search = html_config.search.clone(); let search = html_config.search.clone();

View File

@ -230,6 +230,12 @@
</script> </script>
{{/if}} {{/if}}
{{#if playpen_line_numbers}}
<script type="text/javascript">
window.playpen_line_numbers = true;
</script>
{{/if}}
{{#if playpen_js}} {{#if playpen_js}}
<script src="{{ path_to_root }}ace.js" type="text/javascript" charset="utf-8"></script> <script src="{{ path_to_root }}ace.js" type="text/javascript" charset="utf-8"></script>
<script src="{{ path_to_root }}editor.js" type="text/javascript" charset="utf-8"></script> <script src="{{ path_to_root }}editor.js" type="text/javascript" charset="utf-8"></script>

View File

@ -6,12 +6,14 @@ window.editors = [];
} }
Array.from(document.querySelectorAll('.editable')).forEach(function(editable) { Array.from(document.querySelectorAll('.editable')).forEach(function(editable) {
let display_line_numbers = window.playpen_line_numbers || false;
let editor = ace.edit(editable); let editor = ace.edit(editable);
editor.setOptions({ editor.setOptions({
highlightActiveLine: false, highlightActiveLine: false,
showPrintMargin: false, showPrintMargin: false,
showLineNumbers: false, showLineNumbers: display_line_numbers,
showGutter: false, showGutter: display_line_numbers,
maxLines: Infinity, maxLines: Infinity,
fontSize: "0.875em" // please adjust the font size of the code in general.css fontSize: "0.875em" // please adjust the font size of the code in general.css
}); });