Commit Graph

380 Commits

Author SHA1 Message Date
Vít Stanislav 2ebdcff279
Add "see more" link to GHE-not-supported warning (#609)
* Add "see more" link to GHE-not-supported warning

I lived for several months thinking that support for caching action on GHE is just a matter of time, because it's such an important thing to have. Only today, I discovered that originally it was not planned at all. And that people already created some workarounds. So I hope that linking the issue from the warning message will save other people from what happened to me :-)

* Update new GHE-not-supported message in tests

* Update generated dist files
2021-07-20 10:02:26 -04:00
andrewdotn 5807af2642
Fix bugs in example of how to use with pipenv (#607)
* Fix bugs in example of how to use with pipenv

The current example of how to use `@actions/cache` with pipenv has two
problems:

 1. The cached virtualenv that pipenv creates has `bin/python` as a symlink
    into paths like `/opt/hostedtoolcache/Python/3.7.11` that explicitly
    include the patch version of python. When the cache is restored onto a
    machine running a slightly different version of python, e.g., when
    GitHub upgrades its runners from python 3.7.10 to 3.7.11, then any
    attempt to run python in the workflow mysteriously fails with errors
    like `Failed to load paths: /bin/sh: 1: /home/runner/.local/share/virtualenvs/myrepo-sOIMCiTO/bin/python: not found`.

    Therefore the patch version of python should be included in the cache
    key.

 2. `pipenv --install` has the unfortunate behaviour of not cleaning out
    any pre-existing packages. That is, if the `Pipfile` first contains
    dependencies on `foo` and `bar`, and then you remove `bar` from the
    `Pipfile` and run `pipenv install` again, `bar` is still included in
    the virtualenv.

    This can cause false-positive test failures: when a dependency is
    removed from the `Pipfile` but there is still code that relies on the
    removed dependency, tests can still pass if the dependency comes from
    the cache based on a previous revision of `Pipfile.lock`.

    Therefore `restore-keys` should not be set.

This PR attempts to address both of these issues.

* Explain why setup-python is included in example
2021-07-15 14:37:10 -04:00
Peter Mescalchin 0638051e9a
Golang example tweak - add `go-build` path - rebuild page TOC (#577) 2021-06-01 08:39:29 -05:00
David Hadka c64c572235
Catch and log unhandled exceptions stemming from closed file descriptor (#596) 2021-05-27 10:46:35 -05:00
Alex Tokarev cc2d767a72
Update Rust directories recommended for caching (#433)
This commit applies the suggestion from The Cargo Book:
https://doc.rust-lang.org/cargo/guide/cargo-home.html#caching-the-cargo-home-in-ci
2021-05-21 12:41:57 -05:00
Daniel Kuschny 2fa955d825
Update examples.md (#588)
Extend gradle notes.
2021-05-13 14:40:34 -05:00
Yuichi Yogo 4762de4681 simplify path in lerna example 2021-04-21 02:47:03 +09:00
kalin 3a696372f2
elixir typo - stray parenthesis (#569) 2021-04-20 08:51:44 -05:00
Wojtek Mach 366e5ba022
Update cache key for Elixir (#568) 2021-04-19 08:42:01 -05:00
Yuichi Yogo 12ed05f49a Fix typo of cache path in Lerna example 2021-04-17 12:35:30 +09:00
David Hadka 8d3f2fc3ce
Update dependencies (#565) 2021-04-12 12:21:20 -05:00
David Hadka 1a9e2138d9
Update cache module to v1.0.7 (#562) 2021-04-12 08:57:09 -05:00
Jonathan Clem 981fa981ed
Merge pull request #469 from ericmj/patch-1
Also cache _build for Elixir
2021-03-31 10:46:31 -04:00
Pradyun Gedam 4498c5b4d8
Drop the example based on using pip's internals (#519)
pip's documentation explicitly states to not use `import pip`:

> While it is implemented in Python, and so is available from your Python code via
> `import pip`, you must not use pip’s internal APIs in this way.

This example is in direct contradiction with the documentation's guidance and, thus, has
been removed.
2021-03-29 17:34:02 -04:00
Albert Still 3767bf0386 Improve restore-key documentation 2021-03-26 10:36:55 +11:00
Robert Stoll 4134e6de47
It is not recommended to cache node_modules (#537)
According to the docs of this repo, so the example should not show it
2021-02-17 13:18:00 -05:00
Jason Axelson 2086306d9c Make it more obvious that the cache call does double duty 2021-02-06 13:36:42 -10:00
Yaroslav Dynnikov 26968a09c0
Make save/restore logs akin (#509)
- Print primary key when saving cache
2021-02-03 23:07:49 +01:00
Konrad Pabjan aeaf731ae2
Use @actions/cache version 1.0.6 (#525)
* Use @actions/cache version 1.0.6

* Update cache.dep.yml

* Update all files in .licenses
2021-02-03 22:12:20 +01:00
Konrad Pabjan 56a8a2f775
Merge pull request #514 from eregon/recommend-setup-ruby-bundler-cache
Recommend ruby/setup-ruby's bundler-cache: true option
2021-02-02 21:29:35 +01:00
Benoit Daloze 1bfe3accb3 Recommend ruby/setup-ruby's bundler-cache: true option
Manually caching gems has many issues:
* Not working if there is no Gemfile.lock but only a Gemfile
* Not having the OS version in the key, which might cause binary incompatibility with system libraries of different ABI version.
* Not taking the Ruby version in account.
* Not taking the Ruby ABI version of development builds into accounts, which cannot be done with a key, but needs the commit hash.
* Using restore-keys would grow the cache over time and have extra gems in the cache.
* Those reasons are summarized in https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby#caching-bundle-install-manually
2021-01-28 12:52:25 +01:00
Konrad Pabjan 354332455a
Merge pull request #434 from DanielHabenicht/patch-1
Update examples.md for NPM
2021-01-14 17:22:53 +01:00
Konrad Pabjan 3303695afa
Merge pull request #507 from odin-delrio/patch-1
Improved gradle cache key calculation example
2021-01-14 17:21:10 +01:00
Odín del Río e64ab303d1
Improved gradle cache key calculation example 2021-01-13 22:09:00 +01:00
Konrad Pabjan 26c48dce83
Merge pull request #506 from actions/cache-matrix-example
Added a cache example when using matrix
2021-01-12 13:35:24 -05:00
Chris Patterson 72f66cfa6d
Added a cache example when using matrix 2021-01-12 13:29:18 -05:00
Leandro Ostera 009fe4e01c
Add sample cache for Erlang with Rebar3 2020-12-29 13:33:30 +01:00
Konrad Pabjan 9f3a4d3e65
Merge pull request #443 from guilleijo/pipenv-example
Add example for python pipenv
2020-12-15 16:17:31 -05:00
Aiqiao Yan 7b630ee04f
Merge pull request #483 from actions/aiqiaoy/windows-cache-path
Use @actions/cache 1.0.5
2020-12-15 15:56:11 -05:00
Aiqiao Yan d2583f08bc Run licenses cache 2020-12-11 15:37:37 -05:00
Aiqiao Yan 752e778edb Use @actions/cache 1.0.5 2020-12-11 14:53:36 -05:00
Josh Gross a3047dcdce
Fix CODEOWNER team name (#480) 2020-12-07 15:50:21 -05:00
Konrad Pabjan 9c77c9dbfc
Merge pull request #470 from brcrista/patch-1
Add CODEOWNERS file
2020-11-25 15:25:27 -05:00
Brian Cristante 29cdd22c60
Create CODEOWNERS 2020-11-25 15:14:18 -05:00
Eric Meadows-Jönsson 62a4d75442
Also cache _build for Elixir 2020-11-24 15:52:21 +01:00
David Hadka 0781355a23
Upgrade @actions/cache to 1.0.4 (#451) 2020-11-06 08:23:07 -06:00
David Hadka 22c64ac772
Update @actions/core to 1.2.6 (#449) 2020-11-03 13:04:09 -06:00
Guillermo Eijo cbbf882ea4 Add link to example to README 2020-10-22 22:04:58 -03:00
Guillermo Eijo 4557c6a937 Add example for python pipenv 2020-10-22 21:35:30 -03:00
David Hadka 8819edf476
Update to @actions/cache 1.0.3 (#438)
Update to version 1.0.3 of the `@actions/cache` module.  This pulls in the following changes:

* Add a small delay between retry attempts
* Do not retry on HTTP responses that are not retryable, such as 409 Conflicts
2020-10-20 13:33:34 -05:00
DanielHabenicht 19530ba135
Update examples.md 2020-10-14 02:51:53 +02:00
David Hadka d1255ad936
Merge pull request #424 from actions/dhadka/upload-chunk-size
Adds input for upload chunk size
2020-10-07 15:55:25 -05:00
Dave Hadka 68cfb2ccb7 Add units to description 2020-10-02 11:22:20 -05:00
Dave Hadka cce3c03a74 Add new input to action.yml 2020-10-02 11:01:24 -05:00
Dave Hadka 4bceb75b5b Use parseInt instead of Number to handle empty strings 2020-10-02 10:55:30 -05:00
Dave Hadka a6f1f4b32e Adds input for upload chunk size 2020-10-02 09:59:55 -05:00
David Hadka d606e039ae
Merge pull request #421 from actions/dhadka/ghes
Caching action should no-op on GHES
2020-09-30 17:10:54 -05:00
Dave Hadka d3e4f218f3 Use warning instead of info 2020-09-30 08:47:16 -05:00
Dave Hadka 55a5894438 Update dist 2020-09-29 14:12:21 -05:00
Dave Hadka 3f6dfcbcc4 Merge branch 'main' of http://github.com/actions/cache into dhadka/ghes 2020-09-29 14:01:40 -05:00