From 5cdbd5c7ec0c2f079058d8a75ca2d15388ab1ddd Mon Sep 17 00:00:00 2001 From: itchyny Date: Sun, 14 Apr 2024 22:44:33 +0900 Subject: [PATCH] Avoid re-evaluation of the key input in restore implementation --- dist/restore-only/index.js | 2 +- dist/restore/index.js | 2 +- src/restoreImpl.ts | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dist/restore-only/index.js b/dist/restore-only/index.js index d2f3631..61e434a 100644 --- a/dist/restore-only/index.js +++ b/dist/restore-only/index.js @@ -59427,7 +59427,7 @@ function restoreImpl(stateProvider, earlyExit) { } // Store the matched cache key in states stateProvider.setState(constants_1.State.CacheMatchedKey, cacheKey); - const isExactKeyMatch = utils.isExactKeyMatch(core.getInput(constants_1.Inputs.Key, { required: true }), cacheKey); + const isExactKeyMatch = utils.isExactKeyMatch(primaryKey, cacheKey); core.setOutput(constants_1.Outputs.CacheHit, isExactKeyMatch.toString()); if (lookupOnly) { core.info(`Cache found and can be restored from key: ${cacheKey}`); diff --git a/dist/restore/index.js b/dist/restore/index.js index 842eaa6..ce708ef 100644 --- a/dist/restore/index.js +++ b/dist/restore/index.js @@ -59427,7 +59427,7 @@ function restoreImpl(stateProvider, earlyExit) { } // Store the matched cache key in states stateProvider.setState(constants_1.State.CacheMatchedKey, cacheKey); - const isExactKeyMatch = utils.isExactKeyMatch(core.getInput(constants_1.Inputs.Key, { required: true }), cacheKey); + const isExactKeyMatch = utils.isExactKeyMatch(primaryKey, cacheKey); core.setOutput(constants_1.Outputs.CacheHit, isExactKeyMatch.toString()); if (lookupOnly) { core.info(`Cache found and can be restored from key: ${cacheKey}`); diff --git a/src/restoreImpl.ts b/src/restoreImpl.ts index bb302ac..69d0e94 100644 --- a/src/restoreImpl.ts +++ b/src/restoreImpl.ts @@ -69,11 +69,7 @@ export async function restoreImpl( // Store the matched cache key in states stateProvider.setState(State.CacheMatchedKey, cacheKey); - const isExactKeyMatch = utils.isExactKeyMatch( - core.getInput(Inputs.Key, { required: true }), - cacheKey - ); - + const isExactKeyMatch = utils.isExactKeyMatch(primaryKey, cacheKey); core.setOutput(Outputs.CacheHit, isExactKeyMatch.toString()); if (lookupOnly) { core.info(`Cache found and can be restored from key: ${cacheKey}`);